update ancient greek dict and fonts #12041
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update ancient greek dict
Add ancient Greek fonts from greekfontsociety, with the font license being OFL
Add ancient Greek fonts from Google fonts, with the font license being OFL
|
Thanks for your contribution! |
|
|
|
有人知道， doc/fonts 下的这些字体文件是怎么被使用到的吗？ |
据我所知，好像就画图（可视化）的时候用到。 |
可以用这些字体来生成训练用的文字图片素材 |
|
因为历史原因，在仓库里放了不少的字体文件，我觉得需要重新 review 这么做是否合适。 |
都遵循 如果你觉得有问题，可以不通过字体，通过dict就行 |
|
如果是这样的话。因为现在已经有不少字体已经 vendor in 在仓库里了， PaddleOCR 的部分功能还依赖于这样的做法。所以我觉得新增的字体，现在 vendor in 也没问题。 为了更加合规，你需要在 doc/fonts 目录下，新增一个 README 文件，来说明一下（用英文），你新增的字体的来源和版权，就可以合入了。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.