Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EISeg] Fix grid count calculation #3176

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ishizur
Copy link

@ishizur ishizur commented Apr 14, 2023

PR types

Bug fixes

PR changes

Others (EISeg)

Description

When we annotate large-size images, block mode will be activated for the inference performance.
I've noticed that we cannot annotate the edges of the image in block mode because these parts aren't shown in grids pane.
I found that total grid count calculation might be wrong.
For my understanding, block mode is working like this:
image
And grid count calculation should be like this:
image
So, I submitted this PR.

Finally, thank you for developing such a wonderful tool!馃檹

@CLAassistant
Copy link

CLAassistant commented Apr 14, 2023

CLA assistant check
All committers have signed the CLA.

@shiyutang shiyutang requested a review from haoyuying June 29, 2023 09:31
@shiyutang shiyutang added the contributor Contribution from developers label Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor Contribution from developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants