Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close the popen stream #938

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

close the popen stream #938

wants to merge 4 commits into from

Conversation

luliyucoordinate
Copy link

l think we should close the popen stream before function exits

@luliyucoordinate
close the popen stream
155c177 
l think we should close the popen stream before function exits
@CLAassistant
Copy link

CLAassistant commented Dec 23, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@paddle-bot-old
Copy link

Thanks for your contribution! Please wait for the result of CI firstly.

TeslaZhao
TeslaZhao approved these changes Dec 28, 2020
View reviewed changes
Copy link
Collaborator

@TeslaZhao TeslaZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeslaZhao TeslaZhao TeslaZhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luliyucoordinate @CLAassistant @TeslaZhao