Fix resize and gemm #847
Open
Fix resize and gemm #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjj19950828
requested changes
Jul 28, 2022
| if len(val_x_shape) == 3: | ||
| val_scales = self.graph.get_input_node( | ||
| node, idx=2, copy=True) | ||
| val_scales_values = _const_weight_or_none(val_scales) |
There was a problem hiding this comment.
val_scales_values若没用到则去掉
| scale=alpha) | ||
| else: | ||
| self.paddle_graph.add_layer( | ||
| "paddle.scale", inputs={"x": val_mm}, outputs=[node.name]) |
There was a problem hiding this comment.
如果paddle.scale中alpha值为1，则去掉scale op
wjj19950828
requested changes
Aug 3, 2022
| @@ -1657,6 +1705,12 @@ def Gemm(self, node): | |||
| add_inputs = {"x": val_mm, "y": var_beta} | |||
| self.paddle_graph.add_layer( | |||
| "paddle.add", inputs=add_inputs, outputs=[node.name]) | |||
| else: | |||
| self.paddle_graph.add_layer( | |||
There was a problem hiding this comment.
这里如果scale的alpha为1，是否能去掉scale op呢？
There was a problem hiding this comment.
我尝试在 alpha！=1 的情况下增加scale op, 跑他们那个export_sim.onnx，会转换失败
wjj19950828
approved these changes
Aug 4, 2022
jiangjiajun
requested changes
Aug 5, 2022
| else: | ||
| layer_attrs[pd_attr_name] = False | ||
| else: | ||
| layer_attrs[pd_attr_name] = onnx_attrs[onnx_attr_name] |
There was a problem hiding this comment.
这里是Reduce操作吗， 在ONNX里面keep_dims如果为0，且是所有axis都reduce的情况下， 出来的shape是[]的一个scalar tensor, 而paddle是为[1]的tensor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create A Good Pull Request
Please check the follow step before merging this pull request
If this PR add new model support, please update
model_zoo.mdand add model to out test model zoos(@wjj19950828)主要修改
1 gemm节点input只有两个有效值，没有val_c。进行了修改。
2 Resize节点无法转换，在paddle的interpolate，当mode为nearest时，不支持3d的输入tensor。通过unsqueeze+interpolate+squeeze解决。