【Hackathon 6th No.31】paddle Normal 分布支持复数 #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GGBond8488
reviewed
May 10, 2024
| float mean, | ||
| float std, | ||
| int seed, | ||
| bool complex_gaussian, |
There was a problem hiding this comment.
不要给kernel新增参数，合理的设计是通过模板区分是否是复数类型，然后如果是复数类型则调用对应GaussianKernel 的复数特化，可以参考这种写法，https://github.com/PaddlePaddle/Paddle/pull/63720/files
| template <typename T, typename Context> | ||
| void GaussianKernel(const Context& dev_ctx, | ||
| const IntArray& shape, | ||
| float mean, |
There was a problem hiding this comment.
如果这里复数特化的时候mean用std::complex<float>类型的话，infermeta要怎么改呢
| \end{aligned} $$ | ||
|
|
||
| # 六、测试和验收的考量 | ||
|
|
There was a problem hiding this comment.
测试可以写的更具体一点，要测试哪些性质，比如标准正态分布实部和虚部各自的方差是1/2等等这种
|
@NKNaN 可以先完善一下“测试和验收的考量” 这一部分 |
好的 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.