Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trade search weapon type selection #7538

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

mcmanustfj
Copy link

@mcmanustfj mcmanustfj commented Apr 4, 2024

Fixes #6832.

Description of the problem being solved: Can't change weapon class in trade search.

Especially useful if I have two 1h weapons and want to swap the second one to a shield (or vice versa)

Steps taken to verify a working solution:

  • Create build
  • Add weapon to weapon 2
  • Trade for these items
  • Find best
  • See new "Item Type" dropdown

After screenshot:

image

image

Notes:

  • Currently not doing all base classes, just the important ones
  • Only have possible offhand weapons/shields/quivers for weapon 2, but don't do any validation (i.e. will not stop you from getting a shield and a bow.

@mcmanustfj
Copy link
Author

if any other features start modifying the item class for trade lookup, I would suggest creating a lookup table with all the item types and query strings

@Paliak Paliak added the enhancement New feature, calculation, or mod label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trade search weapon type selection, currently only uses the equipped weapon type.
2 participants