Fix crash caused by Call to Arms conversion #7550
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Call to Arms tattoo has been converted to Warlord's Call. This caused a dismissable crash on importing a build that had one slotted. Finding which tattoo converts to which is quite hard without adding historical tattoo data or some kind of conversion table.
This pr adds logic that attempts to find the new name by comparing available stats. Failing that it removes the tattoo to prevent crash. Added logging in both cases.
Steps taken to verify a working solution: