Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Automation support/skill #7558

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

Paliak
Copy link
Contributor

@Paliak Paliak commented Apr 12, 2024

Description of the problem being solved:

Implements the Automation support/skill.

A new rare specimen of the globalTrigger variety; being a two part skill while behaving like a typical global trigger and, in contrast to others like it, having the cooldown as part of its main display effect and not the supporting effect. Additionally only applies to skills coming from gems (not items or other) that are instant (Steelskin etc.) meaning it can, in theory, trigger another instance of it self.

Link to a build that showcases this PR:

eNq1G9ty4rjyefYrXLxPCBCYzBTZLQK5bYUJC8nMOU9TwhagjSyxspyE_frTkmxjCHJk7JNUJcbqe6tb3W3T_-MtpN4LFhHh7KLROjlteJj5PCBsedF4erz-fN744_ff-hMkVw-Ly5hQtfL7b5_6-tqj-AVTwGt4Eokllj9SSp1fQGmNmFxhzsboby5ueHDR-M4ZbnhzxAIi008-RVH0HYX4ojHzAbnhocjHLBhu7yeAKySQL7G4V1wHseRjHsCqFDGshoiwGfefsbwRPF5roV4IfjUwd-PJw_QxJxJheZFAo0_9CUUbLGYSSS-CPxeNARgGLfEtkUAK0RjonDaahbCXsYjkCIVw-THObI1xsAU76bS6vez3iw1rIvDVYoF9SV7wUBA5XCHmO3ArCzuOqSRrSrDI4FsnXRvG7TvirVMr-UcuER1NZh8LYiC5gwN-Erm6pGBQJ7oK-m7JiMTO4BNOIs5KSe0EPIwphaBygp3iCIsXJImjIEMezglztMmQcxrwV5ZBdk5avXMb9BgxNOTR1jPtsyLQCRYQ1HIH4_QDhBn2OeSBPMqXk-6X7W_PgeNhOlbW92SB3SFLaZUglJXmOD2uZq5wpQkfJ9AUUqIb5IzH1BFSbnNTuyBo_skDtrrWJDbCb2708oD2ELlj0o1cHvDruV26Fy71AemUf65uJznurZN2q9M5PT372u61rEfLahMRH9ExeiNhHEJOf0TPmOXIFOzU5UoyyGM23FbbavZrIvARaENIV8egrRCPjsBTsbh1etGh7n9TsHfMdwvwJyZ0Ws_VAr1ChCmEnSo35hQ7YmxZJMHrckobVkvMEn4bN3XuMfZXN1CNTZHEbrk-g-oWm1XBOplVAR4wa9cRoYSRFKLFSCdfi5BKmumKYbHczFYE06AcdCrYEK2dSlL_Wx7bydy77ErtmDxqSZP8RCJwO3fKyvSConyebfWKzWXA3TYmhhIVEALsWopPBP9bFfu0HNpAhDwWjg43wE4KpEeE6XGmOIh9tzPpkkJz5io9SEVpKYyBlMh_HvFgiUsxKYWR9V0adRav15AxlO9dCaiTDmp4kituPvccoB9g4zrFrzoT3RlsoZ0ZZOe8O5c9FHdd1EFdQpktuDOLzKFjSA0hpHzdko_5Nq9Ya6VraNuc2ioN6NgLTvgrSL5Ss5SoHDQUNNu-zSqKwOzfjTP9HXAnBlcsiIUKBWce-xiH2DySENJmFI2QRF6QVME_kCCIybYe9EQYCX91D66_RpTOIRNcNPJ39Sc9HLomVGIxgnuKqRJsn2IrdXq_qYdc6uouXHMhPfym_k2QkJuLxgLRCBtAfQfoRJIw3ZxDPqK04c1W_HUQvChOj9BcRymSh9ZrzIIdGo8CYw-l2cVXQmjl1QcvRBFIvTHbNVLa5GZkd4FWg3EQAGqc8_NOR-muWjMkNoNdQEZALgm8cqM66NzNFM5QUmw_9Z-m9_ri00rKdfSt2Xx9fT1ZI7niC_wGp9GJz8PmGpBA4M_RM6H0syLbHMDP5XKgfzShZkqpb8ZzUdN8UkEqCMhsnNxUimqrK0uoi-9c4kitqZvph_5MsYrAm0Le4DC63EBgXavqYW_akZhSQc-wNLskj5PODQO8QDFV9_-KESXKs6f5u_dmxMm4CLPGCEiBZ1X-NxQfN2tl-sH9vVkZUJkQU-xSNxt3JgJ5JEhdnNzUE8zBVuohon6k5SbMp3EADUWSc7JtRNFcyaZmtqoZCPKz0ByljNGnPsiTAN9QPke0naIkk1xoU70lDtVGGGOJAoi45p0EJZpKk6YmB1cziTEFp-tzX0eNwsjd1RtC3fsrJv7zTaxLtX9yBk6uFcjI2LqxI1grFWxPNZ_HzHiToTCJlC3f5kdqarnGhMHO3zNyOQOo6XOI0sons0D-dmaCdzdz_DXr_5ddLIxhYR5xGquFRxyuKRJ_xlAFJdbrGyWToEy2qw5ME3rqUptNQ9yxdSw1z4tGSCL_1zxeLNTMHVhKoR8jXF1fXw0f735cJek8j6LF-sXicK7GzOb_9tCdYV1celE8j8zlReMHwa9akBG4h9BIqU4pWkc4y6c6thLJKeAVUNNQtyQb2R-mtQWwU7p6wwLS_xK6El8QbJUrW_9AKMNQdSzq-LNRU6NxOyFTFA_h8DAdlcVS-jGEnYp6GGBVRy0W4MLBiaiVc7L6gSWkyq6wocmC-KpyKHa5ysUGqsAuvg9Fh78p8HdS0dtp6GcNNgJm0Y5sniXYsJPVAqvqJxdWq5pVO_oI-8iqu1m0I2dNOmf6wdhhKhlUAaXvnOlNDkEzIFRV31bPXlGcgdgJPsgVFkmNZKM0hhyVghQGjiDzWNrDOAdRYCs9MrRYSK3ZUc1YzKKDWivIRDujIotB8zB2UmbEYk1kRaimE7PaL-nrClyQDDAs5jerBUZIZzgW_ZPlgiDR-XfwwklgentLuOyBFSUMKH-rk9EDi-pk9icY1SleQwfxbPV3smpHf5JEFT4HqJgCx4mICqpqFFRsVaMw3S8ktrjT4hIia5oPIqerRYGf9NJHUzAd_9HoeiBxNLZO31D0YtCgMH9nMAXbW8ZsBMaQBVvbkZQW63Ae2GpXipY5yQ5qWpqiic_kIVZRCBuQDwjBUXxbUOy5UcqGarcYUfXeBKfVCL57WFdJTy4jxIKReiRQUVH1RCFeA7FUsodD1frWpftU-820j9LTH9XZJDOrmRSqrf-X8_C_ui1UV8kkopNMH6DGHREwtdBbJOWjAP-Tztv6unNNRiHqOp2ExBE2z-5_YrSGVlTdzg0pEtACsN3xBeXSg5IznMyfpvdKcNPcGSxPTTCkaalP0x7ThnKJqfQG800UIeqZeZHXLoGfstyn0S1Po10DjZY3e0XrfUK9GhTq1aBQGRqXHOJmn0CnBIFbDFnvnW-r7o2jzHDIJ90afNKqgcZZSYPUtSfrCLIyNHQZVcrqB3dgu-L-6ZQWuYyDbih_wVGVbXI4anqlKZRWs1VZzTK-HYQxxbKGLdipIS12Kqt-VtrcZfbxFKq0Y-LVJL7SylUN0W5pY1Q_VtqVKVSX4ayq4c7qyu2dUpIEG89MV-rPW926TutWPRq1q7qodAVVObX06tG8W1mQTtmM1apq7FYNub22mOrW44dexfqlejVStYKqKRQ7daWG2ggd01ocZ4u69mRNrjg6RirupNpOh3YNiaIOGq26FKota70n1G8mwx7zppVAAZ7pEdRPrF7bi8ycSs-R9IN_zhZkmb7K5eMVpwEWCWvMcLhJvtSWPsr_kn91-hB8_mtpKVK3GGX3HdQcr4857aN0PpAuec2VUzpFbIeXHTHMvjinvjaGBQ5m-jG8ekNjhuki957DB4qm6SGDbxfDZw-9UoSe3SQRWRL6sNAje5BPP3fYff-i30y93W_ufwH0fyerp8w=

Before screenshot:

obraz

After screenshot:

obraz

@Paliak Paliak added the enhancement New feature, calculation, or mod label Apr 12, 2024
@Paliak
Copy link
Contributor Author

Paliak commented Apr 12, 2024

Since the reduced cooldown recovery rate is on the supporting effect and the cooldown of automation is on the active effect i'm not sure whether or not it should be affected by the reduced cooldown recovery mod (it currently is).

From the wording though "Supported skills.." i'm assuming it is not affected.

Tested it in game. The cooldown reduction mod on the support does not seem to affect the cooldown of automation main effect.

@Paliak Paliak marked this pull request as draft April 12, 2024 23:37
@Paliak Paliak marked this pull request as ready for review May 27, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant