Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeless jewel trade league url #7565

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

tbiering
Copy link

Fixes #7564 .

Description of the problem being solved:

The "Find Timeless Jewel" function does not properly update the selected league for creation of the trade search url.
Details can be found in the bugreport referenced.

Additionally, the window does not restore the last used league when closing and reopening the window.

Steps taken to verify a working solution:

  • Manually performed tests
  • Manually "broke" the HTTP request for fetching the active leagues in order to test fallback scenarios

Before screenshot:

before

After screenshot:

after

@tbiering tbiering force-pushed the fix-timeless-jewel-trade-league-url branch from dd30ecc to 0b45295 Compare April 15, 2024 08:27
@Paliak Paliak added the bug:behaviour Behavioral differences label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:behaviour Behavioral differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find Timeless Jewel's league-selection is not updated for trade site url unless manually triggered
2 participants