Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Player and Minion Info lines if they are too long #7597

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

pHiney
Copy link
Contributor

@pHiney pHiney commented Apr 25, 2024

Fixes image.

Description of the problem being solved:

In some cases the info line is too long and it can't be read.

Steps taken to verify a working solution:

  • Import build into PoB and see that the line is split into two.

Link to a build that showcases this PR:

https://pobb.in/dGqxkOSjJK18 -Minion
https://pobb.in/-viTq9zN-nWg -Player

Before screenshot:

image.

After screenshot:

image

@pHiney pHiney changed the title Split Minion Info line if it's too long Split Player and Minion Info lines if they are too long Apr 26, 2024
else
t_insert(statBoxList, { height = 14, align = "CENTER_X", x = 140, colorCodes.CUSTOM .. self.calcsTab.mainEnv.player.mainSkill.infoMessage})
end
-- t_insert(statBoxList, { height = 14, align = "CENTER_X", x = 140, colorCodes.CUSTOM .. self.calcsTab.mainEnv.player.mainSkill.infoMessage})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-- t_insert(statBoxList, { height = 14, align = "CENTER_X", x = 140, colorCodes.CUSTOM .. self.calcsTab.mainEnv.player.mainSkill.infoMessage})

@Paliak Paliak added the user-interface Changes that only affect the UI label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user-interface Changes that only affect the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants