Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added flasks on template list #4990 #7618

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

n1tr0xs
Copy link

@n1tr0xs n1tr0xs commented May 9, 2024

Fixes #4990.

Description of the problem being solved:

Added one of each utility flask, and eternal/divine life, mana, and hybrid flask on base item

Steps taken to verify a working solution:

  • Check template list in Items tab.

Link to a build that showcases this PR:

No response

Before screenshot:

image

After screenshot:

image

@Regisle
Copy link
Member

Regisle commented May 9, 2024

Adding flasks with no affixes into the template list is a waste as it saves almost no time compared to adding them the "normal" way and just fills the list unnecessarily, the list likely needs to redo anyway, as alot has changed in the years since it was initially implemented.

You should only add commonly used flasks and have an appropriate prefix/suffix (/possibly enchant).

Last time this was brought up it was decided not to add them as they are magic items and are easy to add the other way, but its possible maintainer have changed their stance, though likely not enough to add "blank" magic items

@n1tr0xs
Copy link
Author

n1tr0xs commented May 9, 2024

Ouch... It seems like I really didn't think enough that adding "blank" magic items to templates is not useful.
I'll edit this to be more usefull.

@Regisle
Copy link
Member

Regisle commented May 9, 2024

Ouch... It seems like I really didn't think enough that adding "blank" magic items to templates is not useful. I'll edit this to be more usefull.

My initial response was likely a little blunt, its good to try and add stuff, it was mainly due to similar suggestions being shut down and this not making a huge difference for older users (but likely is very helpful to newer users who do not commonly add items the other way)

If the item is magic anyway then the user will likely want to set a suffix commonly used on the flask anyway, so adding it to begin with will be useful more often than not (and blank items can always be added the other way anyway, or the affixes can just be removed), prefixes/enchants are less likely to be common between builds, the 2 main prefixes for utility flasks are either gain when hit, or increased effect, I would go with the second one if adding enchant (but should be fine to merge without ench/prefix), but adding the first one is semi useless as it doesnt change anything in PoB

2. Added Flasks for Mageblood players.
3. Added auto-use Utility flasks with gain 3 charges prefix.
4. Added instant CB/bleed immune Divine life flask.
@Paliak Paliak added the enhancement New feature, calculation, or mod label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flasks on base item list
3 participants