Better handling for context cancelation while writing to avro #1684
+19
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heavycrystal
reviewed
May 7, 2024
| logger.Error("failed to convert QRecord to Avro compatible map: ", slog.Any("error", err)) | ||
| return 0, fmt.Errorf("failed to convert QRecord to Avro compatible map: %w", err) | ||
| } | ||
| select { |
There was a problem hiding this comment.
I think can be better expressed by ensuring context cancellation closes this channel from upstream
serprex
reviewed
May 7, 2024
| logger.Error("failed to convert QRecord to Avro compatible map: ", slog.Any("error", err)) | ||
| return 0, fmt.Errorf("failed to convert QRecord to Avro compatible map: %w", err) | ||
| } | ||
| select { |
There was a problem hiding this comment.
prefer
if err := ctx.Err(); err != nil {
return numRows, err
} else {
// default
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.