Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Sheet Sources/Triggers Improvements #11711

Merged
merged 13 commits into from May 10, 2024

Conversation

michelle0927
Copy link
Collaborator

@michelle0927 michelle0927 commented Apr 30, 2024

  • Added test events to all sources
  • Move constants.mjs to /common folder
  • Updated new-row-added sources to store row hash in db to check against instead of setting it as meta id for deduping (so that new rows aren't skipped if the id > 64 characters)
  • Updated new-updates sources to shorten the meta id so that items aren't skipped if the id > 64 characters.
  • Combine shared drive & non-shared drive sources
  • New Source - "New Comment"

Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 6:40pm
pipedream-docs ⬜️ Ignored (Inspect) May 9, 2024 6:40pm
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 6:40pm

@michelle0927 michelle0927 self-assigned this May 9, 2024
@michelle0927 michelle0927 added this to Ready for PR review in Component (Source and Action) Backlog May 9, 2024
@dylburger dylburger added the triaged For maintainers: This issue has been triaged by a Pipedream employee label May 9, 2024
Copy link
Collaborator

@lcaresia lcaresia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lcaresia lcaresia moved this from Ready for PR review to Ready for QA in Component (Source and Action) Backlog May 9, 2024
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog May 10, 2024
@vunguyenhung vunguyenhung moved this from In QA to Ready for QA in Component (Source and Action) Backlog May 10, 2024
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog May 10, 2024
@vunguyenhung vunguyenhung moved this from In QA to Ready for release in Component (Source and Action) Backlog May 10, 2024
@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
https://vunguyenhung.notion.site/Google-Sheet-Sources-Triggers-Improvements-11711-47e37eb87b2c4dc08b8cc41fd736ce35

@michelle0927 michelle0927 merged commit 7845401 into master May 10, 2024
11 checks passed
@michelle0927 michelle0927 deleted the google-sheets-improvements branch May 10, 2024 14:24
@michelle0927 michelle0927 moved this from Ready for release to Done in Component (Source and Action) Backlog May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged For maintainers: This issue has been triaged by a Pipedream employee
Development

Successfully merging this pull request may close these issues.

None yet

4 participants