New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Sheet Sources/Triggers Improvements #11711
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
dylburger
added
the
triaged
For maintainers: This issue has been triaged by a Pipedream employee
label
May 9, 2024
lcaresia
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
lcaresia
moved this from Ready for PR review
to Ready for QA
in Component (Source and Action) Backlog
May 9, 2024
vunguyenhung
moved this from Ready for QA
to In QA
in Component (Source and Action) Backlog
May 10, 2024
vunguyenhung
moved this from In QA
to Ready for QA
in Component (Source and Action) Backlog
May 10, 2024
vunguyenhung
moved this from Ready for QA
to In QA
in Component (Source and Action) Backlog
May 10, 2024
vunguyenhung
moved this from In QA
to Ready for release
in Component (Source and Action) Backlog
May 10, 2024
Hi everyone, all test cases are passed! Ready for release! |
michelle0927
moved this from Ready for release
to Done
in Component (Source and Action) Backlog
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new-row-added
sources to store row hash in db to check against instead of setting it as meta id for deduping (so that new rows aren't skipped if the id > 64 characters)new-updates
sources to shorten the meta id so that items aren't skipped if the id > 64 characters.