-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #2055 add time based search #2056
Open
zagl
wants to merge
20
commits into
Piwigo:master
Choose a base branch
from
zagl:issue-2055-time-based-search
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zagl
commented
Dec 5, 2023
Developers who need previous configuration settings can modify them in their local configuration git cherry-pick 5bef564
We present the raw version in the input, and on the rendered version there's a small globe to show that there's a difference between the rendered and raw versions. We have also modified the album title in the album edit page. The rendered version is now displayed, we keep the raw version in the input field.
Which is not the case on install.php and its call to activate_core_plugins
Hi @zagl Do you understand that with the new search engine user interface on Piwigo 14, the "quicksearch" or
I mean that your Pull-Request won't add the time search in the new search engine. |
…rmat The representative jpg file produced for image uploaded in HEIC format is used later to obtain EXIF metadata. Hence don't "strip" HEIC file metadata when corresponding representative is prepared.
When clear is clicked in the "album" filter but the "tag" filter is activated, the clear action in the "album" filter does not work. Because of this line. Clear action in the album filter was clearing both album and tag filters.
zagl
force-pushed
the
issue-2055-time-based-search
branch
from
January 5, 2024 13:39
840bda3
to
5126359
Compare
zagl
force-pushed
the
issue-2055-time-based-search
branch
from
January 5, 2024 13:41
5126359
to
5da2ad3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds time based search in addition to date search.
The regex which parses the date after "created:" or "posted:" now also parses a time if available.
Some examples of time based searches are:
created:2023-12-05T12
orcreated:"2023-12-05 12"
for photos taken at the specified date between 12:00:00 and 12:59:59Date and time might be separated by space or letter T. In case of a space as separator the date has to be placed in quotes.
created:"2023-12-05T12:10"
photos taken between 12:10:00 and 12:10:59In this case the quotes are required because of the colon separator for time.
created:"2023-12-05 1210..2023-12-05 1225"
photos taken between 12:10:00 and 12:25:59created:"2023-12-05 12:10:20..2023-12-05 12:10:37"
photos taken between 12:10:20 and 12:10:37created:">2023-12-05 12:10:20"
photos taken after 12:10:20created:"2023-12-04 12..2023-12-05 12"
datetime ranges accross date borders are also possible