Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #2055 add time based search #2056

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

zagl
Copy link

@zagl zagl commented Dec 5, 2023

This pull request adds time based search in addition to date search.
The regex which parses the date after "created:" or "posted:" now also parses a time if available.

Some examples of time based searches are:
created:2023-12-05T12 or created:"2023-12-05 12" for photos taken at the specified date between 12:00:00 and 12:59:59
Date and time might be separated by space or letter T. In case of a space as separator the date has to be placed in quotes.

created:"2023-12-05T12:10" photos taken between 12:10:00 and 12:10:59
In this case the quotes are required because of the colon separator for time.

created:"2023-12-05 1210..2023-12-05 1225" photos taken between 12:10:00 and 12:25:59
created:"2023-12-05 12:10:20..2023-12-05 12:10:37" photos taken between 12:10:20 and 12:10:37
created:">2023-12-05 12:10:20" photos taken after 12:10:20
created:"2023-12-04 12..2023-12-05 12" datetime ranges accross date borders are also possible

plegall and others added 10 commits December 11, 2023 14:45
Developers who need previous configuration settings can modify them in their local configuration

git cherry-pick 5bef564
We present the raw version in the input, and on the rendered version there's a small globe to show that there's a difference between the rendered and raw versions.

We have also modified the album title in the album edit page. The rendered version is now displayed, we keep the raw version in the input field.
Which is not the case on install.php and its call to activate_core_plugins
@plegall
Copy link
Member

plegall commented Dec 22, 2023

Hi @zagl

Do you understand that with the new search engine user interface on Piwigo 14, the "quicksearch" or qsearch as you can find in PHP code, is only used in 2 places:

  1. in API method pwg.images.search
  2. in administration batch manager with the "search" filter

I mean that your Pull-Request won't add the time search in the new search engine.

plegall and others added 8 commits December 26, 2023 10:27
…rmat

The representative jpg file produced for image uploaded in HEIC
format is used later to obtain EXIF metadata. Hence don't "strip"
HEIC file metadata when corresponding representative is prepared.
When clear is clicked in the "album" filter but the "tag" filter is activated, the clear action in the "album" filter does not work. Because of this line.

Clear action in the album filter was clearing both album and tag filters.
@zagl zagl force-pushed the issue-2055-time-based-search branch from 840bda3 to 5126359 Compare January 5, 2024 13:39
@zagl zagl force-pushed the issue-2055-time-based-search branch from 5126359 to 5da2ad3 Compare January 5, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants