Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed compression for node runtime since its buffering the response during streaming #309

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mohankumarelec
Copy link

Title:

  • Removed compression for node runtime since its buffering the response during streaming

Description:

  • Removed compression middleware if runtime is node
  • Removed content-encoding header to disabled compression for node

Motivation:

  • Adding compression middleware buffers the response while streaming, defeating the purpose of streaming

Related Issues:

@flexchar
Copy link
Contributor

Actually I am using image where I also disable it. I would propose completely removing it. The benefit is less than the pain it can cause, and in the context of streaming it's not giving much anyways.

Copy link

@arbi-dev arbi-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Streaming is very important, please implement this or another fix.

@VisargD
Copy link
Collaborator

VisargD commented May 20, 2024

Hey all. I will verify and merge these changes. Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants