-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sort the simple key value list #22335
Conversation
Size Change: +240 B (+0.02%) Total Size: 1.05 MB ℹ️ View Unchanged
|
const promotedItems = promotedKeys?.length ? sortedItems.filter(([key]) => promotedKeys.includes(key)) : [] | ||
const nonPromotedItems = promotedKeys?.length | ||
? sortedItems.filter(([key]) => !promotedKeys.includes(key)) | ||
: sortedItems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some type of partition
method would be cool but I don't think we have one
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
frontend/src/scenes/session-recordings/player/inspector/components/SimpleKeyValueList.tsx
Outdated
Show resolved
Hide resolved
…ents/SimpleKeyValueList.tsx
frontend/src/scenes/session-recordings/player/inspector/components/SimpleKeyValueList.tsx
Outdated
Show resolved
Hide resolved
…ents/SimpleKeyValueList.tsx
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
As part of the #mykologs hackathon
Sorting the simple key value list was surprisingly amazing
This also lets the caller promote particular properties