-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove most frontend references to available_features #22337
Conversation
Hey @xrdt! 馃憢 |
馃摳 UI snapshots have been updated22 snapshot changes in total. 0 added, 22 modified, 0 deleted:
Triggered by this commit. |
Size Change: -28 B (0%) Total Size: 1.05 MB 鈩癸笍 View Unchanged
|
馃摳 UI snapshots have been updated22 snapshot changes in total. 0 added, 22 modified, 0 deleted:
Triggered by this commit. |
e099ce4
to
9a4ee34
Compare
馃摳 UI snapshots have been updated22 snapshot changes in total. 0 added, 22 modified, 0 deleted:
Triggered by this commit. |
The experiments test keeps failing. I've asked for guidance about it on this PR: #22339 |
馃摳 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
馃摳 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work on this!
* remove most frontend references to available_features * some more * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * adding back some items, fix tests * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * fix test * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (1) --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* remove most frontend references to available_features * some more * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * adding back some items, fix tests * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * fix test * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (1) --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Problem
I'm going to deprecate this in stages. This PR mainly removed frontend references to available_features and switched to using hasAvailableFeature when feature checks are necessary.
The next PR will handle the backend side of references to available_features.
The final PR will remove the database fields.
Changes
馃憠 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?