Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: network waterfall view for session replay #22349

Merged
merged 45 commits into from
May 24, 2024
Merged

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented May 18, 2024

#TravelHackathon

We have all the data we need to generate page reports in individual recording's session replay data

We can't make it queryable but we can display it individually, that's already useful so let's do that

Screenshot 2024-05-19 at 22 16 19

TODO

  • react to playlist ID changes
  • show breakdown of asset types by size
  • allow filtering to remove asset types from view
  • make it exportable?
  • make it work with notebooks
  • change the URL when e.g. paging so you can share with others
  • allow public sharing?
  • make an aggregate view that shows the whole session collapsed by URL with box-plots

if it's a mode of the player we can ignore

  • don't mark as viewed?

@pauldambra pauldambra requested a review from daibhin May 18, 2024 08:12
Copy link
Contributor

github-actions bot commented May 18, 2024

Size Change: +58 B (+0.01%)

Total Size: 1.03 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.03 MB +58 B (+0.01%)

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@pauldambra
Copy link
Member Author

@daibhin thought I'd put something up you can play with to get UX feedback - am already thinking it should be called "page report" not "network view"

coderabbitai[bot]

This comment was marked as spam.

@PostHog PostHog deleted a comment from coderabbitai bot May 19, 2024
coderabbitai[bot]

This comment was marked as spam.

@pauldambra
Copy link
Member Author

@PostHog PostHog deleted a comment from coderabbitai bot May 19, 2024
@daibhin
Copy link
Contributor

daibhin commented May 20, 2024

This feels cool. Great to give people another means of analysing their data. I made two larger changes:

  • Put the contents into a table for easier formatting
  • Cleaned up the asset proportions to hide text on smaller screens

I think the main question I took away from it all was why this is a separate tab to the recordings? I'd imagine it would be quite annoying to have to switch between the two tabs and find a recording again if you want to look at the waterfall view.

Do we expect someone to use this while analysing a recording or is it something they'd intentionally come to do? Could this be a different view on the existing recording that you can toggle to? Or maybe it could just be another tab in the inspector?

@pauldambra
Copy link
Member Author

I think the main question I took away from it all was why this is a separate tab to the recordings?

Yeah, I think eventually you'd want to be able to visit individual page reports, share them, export them.

It was separate mostly just cos I was figuring it out as I go. And a way to promote the feature more easily.


I don't think it should live only in the inspector. It feels too restricted.


I'd be keen to get it in behind a flag so we can see the display with some production data to sense check that.

@pauldambra
Copy link
Member Author

super confused why moving the initiator type color mapping has broken all uses of color in js tests 🫠

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

  • chromium: 0 added, 3 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Member

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low context approval given :D since it's behind a flag anyways

@pauldambra pauldambra merged commit b4b8cac into master May 24, 2024
83 checks passed
@pauldambra pauldambra deleted the feat/waterfall-view branch May 24, 2024 12:06
timgl pushed a commit that referenced this pull request May 24, 2024
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: David Newell <david@posthog.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants