-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: async validation errors #22351
fix: async validation errors #22351
Conversation
Size Change: +172 B (+0.02%) Total Size: 1.05 MB ℹ️ View Unchanged
|
@@ -329,6 +329,10 @@ export const insightVizDataLogic = kea<insightVizDataLogicType>([ | |||
validationError: [ | |||
(s) => [s.insightDataError], | |||
(insightDataError): string | null => { | |||
// Handle Async Queries here | |||
if (insightDataError?.data?.error_message) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question: does this only apply to async HogQL queries, or HogQL queries overall? Because if the shape of insightDataError
is different for async ones specifically, that sounds like a minefield
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, so they're pretty significantly different. That's a bit annyoing. But let's maybe keep as is for now, and only fix the problem at hand.
Problem
Async user surfaceable queries don't have user friendly errors
#21270
Changes
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Tested locally