Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable cli autocompletion #13292

Merged
merged 1 commit into from May 17, 2024
Merged

enable cli autocompletion #13292

merged 1 commit into from May 17, 2024

Conversation

zzstoatzz
Copy link
Contributor

@zzstoatzz zzstoatzz commented May 9, 2024

not sure why we had this turned off

when on, allows

» prefect --install-completion

which gives

image

@zzstoatzz zzstoatzz requested a review from a team as a code owner May 9, 2024 18:23
Copy link

netlify bot commented May 9, 2024

Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit 68defcc
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/663d149ff00dc80008a6ae09
😎 Deploy Preview https://deploy-preview-13292--prefect-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zzstoatzz zzstoatzz self-assigned this May 9, 2024
@zzstoatzz zzstoatzz added the enhancement An improvement of an existing feature label May 9, 2024
Copy link
Collaborator

@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I recall, it was because we weren't happy with the import times (and still aren't). In my opinion, that should make us want to speed up imports, not disable completions! Thanks for turning this back on

@serinamarie
Copy link
Contributor

I think the changes being made to speed up the CLI mean that this can be merged.
Since Andrew and I needed to add the following lines to our .zshrc to enable this, I wonder if there is any easy way to mention this in the help message. Certainly not blocking, though.

autoload -Uz compinit
zstyle ':completion:*' menu select
fpath+=~/.zfunc
compinit

@zzstoatzz zzstoatzz merged commit e9b5da6 into main May 17, 2024
57 of 59 checks passed
@zzstoatzz zzstoatzz deleted the auto-complete branch May 17, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants