Hi, thanks for this contribution!

I found some issues with the Pull Request description:

• The type should be one of these: new feature, improvement, bug fix or refacto (Read explanation).

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

(Note: this is an automated message, but answering it will reach a real human)

This could be used by some templates to list all possible variants. 🤔
Ping @kpodemski @ShaiMagal

I can (hardly) imagine themes created for 1.6 and then upgraded all the way to 8.1.x.
Is it reason enough to keep code unused in the core since 2016?

Hello @the-ge

While I could agree that this method has been rarely used, we cannot just remove it, we need to deprecate it first, and then remove it in the next major release.

Well, the method is used by the core itself on every product page creation. What's not used is its work result. Deprecating this method will only fill the log with deprecation messages telling the core developers to stop using it. Am I missing something?

@the-ge that's why I like your fix from separate PR better, it fixes the problem while keeping everything working

Hmm, the way I'm seeing them now, these are the choices:

1. We apply the 36039 patch for a minor optimization. The controller will still waste resources on unused processing and there's still no clear path to the useless code retirement.
2. We apply this patch, rendering 36039 irrelevant. The potential issue is now the existence of a theme that's using this code. We are on the develop branch, which means the theme should've been created for PrestaShop 1.6 and then updated to 1.7, then updated to 8.0, then updated to 8.1. And we do not want to affect the said theme, because...

Well, I do not really know why a theme with v1.6 legacy code should be protected. From my point of view, the PrestaShop theme market state is not that good - saturated with builder-based monsters creating multi-MB JavaScript and, worse, multi-MB CSS pages with abysmal performance. Choosing legacy instead of performance only adds to this state.