Removed unused ProductController::assignAttributesCombinations() method and call #36056
+0
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProductController::assignAttributesCombinations()
method assigns an array of attribute combinations (with size being the count of attributes x count of product combinations, i.e. 4 x 5000 in my case) as a Smarty template variable. As the count of attributes and product combinations increase, this consumes more and more resources. Recent improvements directed at reducing resources consumed are #34453 and #36039. The thing is, the template variable this method assigns seems to have been last used in PrestaShop v1.6, so the method and the call to it should be removed altogether.