Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation prestashop product flag (New) #36076

Closed
2 tasks done
medMethnani opened this issue May 2, 2024 · 6 comments
Closed
2 tasks done

Translation prestashop product flag (New) #36076

medMethnani opened this issue May 2, 2024 · 6 comments
Labels
Bug Type: Bug

Comments

@medMethnani
Copy link

Prerequisites

Describe the bug and add attachments

The translation of the product flag New is not working in any language, after checking i found a bug on Prestashop 8.X
This is my pull request to fix the issue : #36067
new_traduction

Expected behavior

This problem is related to Prestashop multi-languges only

Steps to reproduce

  1. Add new language pack in prestashop Ex: French
  2. In front end check new product badge it will show New instead of Nouveau
    NB: even if you translate the New => Nouveau from the backend it will not work

PrestaShop version(s) where the bug happened

8.X

PHP version(s) where the bug happened

8.X

If your bug is related to a module, specify its name and its version

No response

Your company or customer's name goes here (if applicable).

MedMethnani

@medMethnani medMethnani added Bug Type: Bug New New issue not yet processed by QA labels May 2, 2024
@Hlavtox
Copy link
Contributor

Hlavtox commented May 3, 2024

@medMethnani The field is translatable just fine.

  1. Go to Translations > Front office translations > Core (no theme selected) > French.
  2. Search for new.
  3. Click Shop > Theme > Global in the left column
  4. Find New and translate.

@medMethnani
Copy link
Author

@Hlavtox Thank you for your answer.
That's exactly what I did, the translation always shows New instead of Nouveau in front office.
Be aware that I'm testing on fresh install of Prestashop 8.1.1 origin with English language then I added the French package.
I tested other versions of Prestashop and it seems the problem is on PS 8.X
This is my pull request to fix the issue : #36067

@Hlavtox
Copy link
Contributor

Hlavtox commented May 3, 2024

@medMethnani Isn't it just homepage modules cache? Did you clearing cache?

@medMethnani
Copy link
Author

Yes of course :)

@florine2623
Copy link
Contributor

Hello @medMethnani ,

I can't reproduce your issue :

Screen.Recording.2024-05-14.at.15.17.46.mov

If you need support, you can find resources to help you on this page: Get help with PrestaShop.

Alternatively, you can also ask for help in the community forums or in the public Slack channel.

Thank you

@florine2623 florine2623 removed the New New issue not yet processed by QA label May 14, 2024
@medMethnani
Copy link
Author

Hello @florine2623 , in fact to reproduce the issue please follow this steps:

  • Add new language pack in prestashop Ex: French
  • In front end check new product badge it will show New instead of Nouveau

NB: even if you translate the New => Nouveau from the backend it will not work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Type: Bug
Projects
None yet
Development

No branches or pull requests

3 participants