Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flag new traduction #36067

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

medMethnani
Copy link

@medMethnani medMethnani commented May 1, 2024

Questions Answers
Branch? develop / 8.1.x
Description? Fix the New flag on product image translation from back office.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? The traduction will now show correctly on front page on the New products with badge New well translated if its French langue it show Nouveau,...
UI Tests [Please run UI tests and paste here the link to the run. Read this page to know why and how to use this tool..](https://github.com/medMethnani/ga.tests.ui.pr/actions/runs/8915646840)
Fixed issue or discussion? NONE
Related PRs NONE
Sponsor company Med METHNANI.

@prestonBot
Copy link
Collaborator

Hello @medMethnani!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • The category should be one of these: BO, CO, FO, IN, LO, ME, PM, TE or WS (Read explanation)
  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added the Bug fix Type: Bug fix label May 1, 2024
@medMethnani medMethnani marked this pull request as ready for review May 1, 2024 22:18
@medMethnani medMethnani requested a review from a team as a code owner May 1, 2024 22:18
@nicosomb nicosomb added the Waiting for wording Status: action required, waiting for wording label May 2, 2024
Copy link
Contributor

@Hlavtox Hlavtox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been changed back and forth many times. Before changing anything, we need to analyze the situation.

Update, checked it out. Nothing to change here. French translators need to fix this translation.

@ps-jarvis ps-jarvis added the Waiting for author Status: action required, waiting for author feedback label May 2, 2024
@medMethnani
Copy link
Author

Hello, this is my first contribution on Prestashop if you can help me what should i do next ?
Because there is a bug i'm sure 100% on the prestashop Backoffice related to the translation.
Thanks.

@prestashop-issue-bot prestashop-issue-bot bot removed the Waiting for author Status: action required, waiting for author feedback label May 2, 2024
Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@medMethnani hello, and thank you for your contribution 👍

You should create an issue, with detailed steps to reproduce the bug, then the QA team will try to reproduce it, and from there we'll see what must be done.

Then you can link the issue in your PR's description, so that next reviewers can check it out

@medMethnani
Copy link
Author

Hello @matthieu-rolland , thanks for your answer this is the bug link: #36076
What to do next :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug fix Type: Bug fix Waiting for wording Status: action required, waiting for wording
Projects
Status: Waiting for author
Development

Successfully merging this pull request may close these issues.

None yet

6 participants