Try to enable MariaDB in CI #36049

nicosomb · 2024-04-29T13:04:21Z

Questions	Answers
Branch?	develop / 8.1.x
Description?	Please be specific when describing the PR. Every detail helps: versions, browser/server configuration, specific module/theme, etc. Feel free to add more information below this table.
Type?	bug fix / improvement / new feature / refacto
Category?	FO / BO / CO / IN / WS / TE / LO / ME / PM
BC breaks?	yes / no
Deprecations?	yes / no
How to test?	Indicate how to verify that this change works as expected.
UI Tests	Please run UI tests and paste here the link to the run. Read this page to know why and how to use this tool..
Fixed issue or discussion?	Fixes #{issue number here}, Fixes #{another issue number here}, Fixes https://github.com/PrestaShop/PrestaShop/discussions/ {discussion number here}
Related PRs	If theme, autoupgrade or other module change is needed to make this change work, provide a link to related PRs here.
Sponsor company	Your company or customer's name goes here (if applicable).

prestonBot · 2024-04-29T13:04:26Z

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

The category should be one of these: BO, CO, FO, IN, LO, ME, PM, TE or WS (Read explanation)

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

(Note: this is an automated message, but answering it will reach a real human)

grooverdan

sorry I can't see the cause of the integration test failure.

grooverdan · 2024-04-29T22:47:27Z

.github/workflows/integration.yml

-      - name: Change MySQL authentication method
-        run: mysql -h127.0.0.1 -uroot -ppassword -e "ALTER USER 'root'@'%' IDENTIFIED WITH mysql_native_password BY 'password'; FLUSH PRIVILEGES;"
+      - name: Change MariaDB authentication method
+        run: mysql -h127.0.0.1 -uroot -ppassword -e "ALTER USER root@localhost IDENTIFIED VIA mysql_native_password USING PASSWORD('password'); FLUSH PRIVILEGES;"


This chunk isn't needed. The mysql root password of the getlong/mariadb-action will set the password. Also `FLUSH PRIVILEGES isn't required after any ALTER USER or other SQL statement granting privs/user changes.

I tried to remove it, but it fails too. I don't know why, I can't debug the error https://github.com/PrestaShop/PrestaShop/actions/runs/8892768244/job/24417552756?pr=36049
if you have any idea ...

grooverdan · 2024-05-01T06:58:26Z

I tested locally on PrestaShop 44c66da

Against MariaDB-11.5 (with my delete single table alias extensions MariaDB/server#3237)

$ composer run-script integration-tests --timeout=0
> @php ./tests/bin/create-test-db.php
Testing database settings
Creating database test_prestashop
Creating database test_prestashop
Dropping database tables
Installing database
Dropping database tables
Initializing test context
Installing default data
Populating database
Configuring shop
Installing language
Installing fixtures
Cannot create image "Dade_County" for entity "store"
Cannot create image "E_Fort_Lauderdale" for entity "store"
Cannot create image "Pembroke_Pines" for entity "store"
Cannot create image "Coconut_Grove" for entity "store"
Cannot create image "N_Miami_Biscayne" for entity "store"
Installing theme classic
Installing modules on disk
Cannot install module "ganalytics"
Creating database dump
Backup resources
Test DB was successfully created
> @php ./tests/bin/create-test-tables-dump.php
> @php -d date.timezone=UTC -d memory_limit=-1 ./vendor/phpunit/phpunit/phpunit -c tests/Integration/phpunit.xml
PHPUnit 9.6.19 by Sebastian Bergmann and contributors.

.............................................................   61 / 1307 (  4%)
.............................................................  122 / 1307 (  9%)
.............................................................  183 / 1307 ( 14%)
.............................................................  244 / 1307 ( 18%)
.............................................................  305 / 1307 ( 23%)
.............................................................  366 / 1307 ( 28%)
.............................................................  427 / 1307 ( 32%)
.............................................................  488 / 1307 ( 37%)
.............................................................  549 / 1307 ( 42%)
.............................................................  610 / 1307 ( 46%)
.............................................................  671 / 1307 ( 51%)
.............................................................  732 / 1307 ( 56%)
.............................................................  793 / 1307 ( 60%)
.............................................................  854 / 1307 ( 65%)
.............................................................  915 / 1307 ( 70%)
.............................................................  976 / 1307 ( 74%)
............................................................. 1037 / 1307 ( 79%)
............................................................. 1098 / 1307 ( 84%)
............................................................. 1159 / 1307 ( 88%)
............................................................. 1220 / 1307 ( 93%)
............................................................. 1281 / 1307 ( 98%)
..........................                                    1307 / 1307 (100%)

Time: 01:31.491, Memory: 708.00 MB

OK (1307 tests, 10958 assertions)

THE ERROR HANDLER HAS CHANGED!

Remaining self deprecation notices (1633)

Remaining direct deprecation notices (407)

Remaining indirect deprecation notices (5475)

Other deprecation notices (871)
> @php -d date.timezone=UTC ./vendor/phpunit/phpunit/phpunit -c tests/Integration/phpunit-isolated.xml
PHPUnit 9.6.19 by Sebastian Bergmann and contributors.

.PrestaShopException in /home/dan/repos/PrestaShop/classes/db/DbPDO.php line 151
#0 /home/dan/repos/PrestaShop/classes/db/Db.php(381): DbPDOCore->_query()
#1 /home/dan/repos/PrestaShop/classes/db/Db.php(618): DbCore->query()
#2 /home/dan/repos/PrestaShop/classes/shop/Shop.php(1365): DbCore->executeS()
#3 /home/dan/repos/PrestaShop/classes/shop/Shop.php(356): ShopCore::findShopByHost()
#4 /home/dan/repos/PrestaShop/config/config.inc.php(122): ShopCore::initialize()
#5 /home/dan/repos/PrestaShop/bin/console(18): require_once('...')
#6 {main}
PrestaShopException in /home/dan/repos/PrestaShop/classes/db/DbPDO.php line 151
#0 /home/dan/repos/PrestaShop/classes/db/Db.php(381): DbPDOCore->_query()
#1 /home/dan/repos/PrestaShop/classes/db/Db.php(618): DbCore->query()
#2 /home/dan/repos/PrestaShop/classes/shop/Shop.php(1365): DbCore->executeS()
#3 /home/dan/repos/PrestaShop/classes/shop/Shop.php(356): ShopCore::findShopByHost()
#4 /home/dan/repos/PrestaShop/config/config.inc.php(122): ShopCore::initialize()
#5 /home/dan/repos/PrestaShop/bin/console(18): require_once('...')
#6 {main}
.PrestaShopException in /home/dan/repos/PrestaShop/classes/db/DbPDO.php line 151
#0 /home/dan/repos/PrestaShop/classes/db/Db.php(381): DbPDOCore->_query()
#1 /home/dan/repos/PrestaShop/classes/db/Db.php(618): DbCore->query()
#2 /home/dan/repos/PrestaShop/classes/shop/Shop.php(1365): DbCore->executeS()
#3 /home/dan/repos/PrestaShop/classes/shop/Shop.php(356): ShopCore::findShopByHost()
#4 /home/dan/repos/PrestaShop/config/config.inc.php(122): ShopCore::initialize()
#5 /home/dan/repos/PrestaShop/bin/console(18): require_once('...')
#6 {main}
PrestaShopException in /home/dan/repos/PrestaShop/classes/db/DbPDO.php line 151
#0 /home/dan/repos/PrestaShop/classes/db/Db.php(381): DbPDOCore->_query()
#1 /home/dan/repos/PrestaShop/classes/db/Db.php(618): DbCore->query()
#2 /home/dan/repos/PrestaShop/classes/shop/Shop.php(1365): DbCore->executeS()
#3 /home/dan/repos/PrestaShop/classes/shop/Shop.php(356): ShopCore::findShopByHost()
#4 /home/dan/repos/PrestaShop/config/config.inc.php(122): ShopCore::initialize()
#5 /home/dan/repos/PrestaShop/bin/console(18): require_once('...')
#6 {main}
.PrestaShopException in /home/dan/repos/PrestaShop/classes/db/DbPDO.php line 151
#0 /home/dan/repos/PrestaShop/classes/db/Db.php(381): DbPDOCore->_query()
#1 /home/dan/repos/PrestaShop/classes/db/Db.php(618): DbCore->query()
#2 /home/dan/repos/PrestaShop/classes/shop/Shop.php(1365): DbCore->executeS()
#3 /home/dan/repos/PrestaShop/classes/shop/Shop.php(356): ShopCore::findShopByHost()
#4 /home/dan/repos/PrestaShop/config/config.inc.php(122): ShopCore::initialize()
#5 /home/dan/repos/PrestaShop/bin/console(18): require_once('...')
#6 {main}
PrestaShopException in /home/dan/repos/PrestaShop/classes/db/DbPDO.php line 151
#0 /home/dan/repos/PrestaShop/classes/db/Db.php(381): DbPDOCore->_query()
#1 /home/dan/repos/PrestaShop/classes/db/Db.php(618): DbCore->query()
#2 /home/dan/repos/PrestaShop/classes/shop/Shop.php(1365): DbCore->executeS()
#3 /home/dan/repos/PrestaShop/classes/shop/Shop.php(356): ShopCore::findShopByHost()
#4 /home/dan/repos/PrestaShop/config/config.inc.php(122): ShopCore::initialize()
#5 /home/dan/repos/PrestaShop/bin/console(18): require_once('...')
#6 {main}
PrestaShopException in /home/dan/repos/PrestaShop/classes/db/DbPDO.php line 151
#0 /home/dan/repos/PrestaShop/classes/db/Db.php(381): DbPDOCore->_query()
#1 /home/dan/repos/PrestaShop/classes/db/Db.php(618): DbCore->query()
#2 /home/dan/repos/PrestaShop/classes/shop/Shop.php(1365): DbCore->executeS()
#3 /home/dan/repos/PrestaShop/classes/shop/Shop.php(356): ShopCore::findShopByHost()
#4 /home/dan/repos/PrestaShop/config/config.inc.php(122): ShopCore::initialize()
#5 /home/dan/repos/PrestaShop/bin/console(18): require_once('...')
#6 {main}
.....................                                          24 / 24 (100%)

Time: 00:28.129, Memory: 181.00 MB

OK (24 tests, 72 assertions)

Remaining self deprecation notices (6)

Remaining indirect deprecation notices (546)

Other deprecation notices (14)

Against MariaDB-10.11.8- ae03374f29944f4ae5cbc4df80d7273f2476dcff (current latest) / and 10.4.34-f378e7643459f0baa6c4149a795463f2f46b6871 (current latest).

$ composer run-script integration-tests --timeout=0
> @php ./tests/bin/create-test-db.php
Testing database settings
Creating database test_prestashop
Creating database test_prestashop
Dropping database tables
Installing database
Dropping database tables
Initializing test context
Installing default data
Populating database
Configuring shop
Installing language
Installing fixtures
Cannot create image "Dade_County" for entity "store"
Cannot create image "E_Fort_Lauderdale" for entity "store"
Cannot create image "Pembroke_Pines" for entity "store"
Cannot create image "Coconut_Grove" for entity "store"
Cannot create image "N_Miami_Biscayne" for entity "store"
Installing theme classic
Installing modules on disk
Cannot install module "ganalytics"
Creating database dump
Backup resources
Test DB was successfully created
> @php ./tests/bin/create-test-tables-dump.php
> @php -d date.timezone=UTC -d memory_limit=-1 ./vendor/phpunit/phpunit/phpunit -c tests/Integration/phpunit.xml
PHPUnit 9.6.19 by Sebastian Bergmann and contributors.

.............................................................   61 / 1307 (  4%)
.............................................................  122 / 1307 (  9%)
.............................................................  183 / 1307 ( 14%)
..........................................................FFF  244 / 1307 ( 18%)
.............................................................  305 / 1307 ( 23%)
.............................................................  366 / 1307 ( 28%)
.............................................................  427 / 1307 ( 32%)
.............................................................  488 / 1307 ( 37%)
.............................................................  549 / 1307 ( 42%)
.............................................................  610 / 1307 ( 46%)
.............................................................  671 / 1307 ( 51%)
.............................................................  732 / 1307 ( 56%)
.............................................................  793 / 1307 ( 60%)
.............................................................  854 / 1307 ( 65%)
.............................................................  915 / 1307 ( 70%)
.............................................................  976 / 1307 ( 74%)
............................................................. 1037 / 1307 ( 79%)
............................................................. 1098 / 1307 ( 84%)
............................................................. 1159 / 1307 ( 88%)
............................................................. 1220 / 1307 ( 93%)
............................................................. 1281 / 1307 ( 98%)
..........................                                    1307 / 1307 (100%)

Time: 01:22.072, Memory: 694.00 MB

There were 3 failures:

1) Tests\Integration\Classes\CartRuleTest::testGetAllCustomersCartRulesInMyAccountZone
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => '4'
-    1 => '8'
-    2 => '2'
-    3 => '6'
+    0 => 2
+    1 => 4
+    2 => 6
+    3 => 8
 )

/home/dan/repos/PrestaShop/tests/Integration/Classes/CartRuleTest.php:213

2) Tests\Integration\Classes\CartRuleTest::testGetAllCustomersCartRulesInBackoffice
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => '8'
-    1 => '6'
-    2 => '4'
-    3 => '2'
-    4 => '9'
+    0 => 2
+    1 => 4
+    2 => 6
+    3 => 8
+    4 => 9
 )

/home/dan/repos/PrestaShop/tests/Integration/Classes/CartRuleTest.php:255

3) Tests\Integration\Classes\CartRuleTest::testGetHighlightedVouchersInCart
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => '1'
-    1 => '5'
-    2 => '2'
-    3 => '6'
+    0 => 1
+    1 => 2
+    2 => 5
+    3 => 6
 )

/home/dan/repos/PrestaShop/tests/Integration/Classes/CartRuleTest.php:308

FAILURES!
Tests: 1307, Assertions: 10957, Failures: 3.

THE ERROR HANDLER HAS CHANGED!

Remaining self deprecation notices (1633)

Remaining direct deprecation notices (407)

Remaining indirect deprecation notices (5470)

Other deprecation notices (862)
Script @php -d date.timezone=UTC -d memory_limit=-1 ./vendor/phpunit/phpunit/phpunit -c tests/Integration/phpunit.xml handling the integration-tests event returned with error code 1

Still can't see why gh actions fails on "create-test-db"

nicosomb · 2024-05-02T07:08:14Z

@grooverdan thank you for your tests.
locally I don't have any problem too ... I don't understand.

grooverdan · 2024-05-02T08:27:07Z

Glad one of does have it working ok :-).

Maybe mariadb not fully running for some reason. As a step before testing

until mysql -h 127.0.0.1 -u root  -ppassword -e 'select 1'; do sleep 1; echo not there yet; done; echo "ready"

nicosomb added the WIP Status: Work In Progress label Apr 29, 2024

prestonBot added Bug fix Type: Bug fix BC break Type: Introduces a backwards-incompatible break labels Apr 29, 2024

nicosomb closed this Apr 29, 2024

nicosomb reopened this Apr 29, 2024

nicosomb force-pushed the mariadb-in-ci branch 3 times, most recently from e6d9877 to 3118469 Compare April 29, 2024 14:57

grooverdan reviewed Apr 29, 2024

View reviewed changes

nicosomb mentioned this pull request Apr 30, 2024

MariaDB Incompatibility #33157

Open

2 tasks

nicosomb added 3 commits April 30, 2024 11:49

Try to enable MariaDB in CI

239672f

try to fix version

56e96ed

Try to remove the change section

ae0f8c6

nicosomb force-pushed the mariadb-in-ci branch from 36f0b90 to ae0f8c6 Compare April 30, 2024 09:50

Add a sleep

9d567a5

nicosomb closed this May 2, 2024

nicosomb reopened this May 2, 2024

nicosomb added 2 commits May 2, 2024 13:02

add log

efd5aa4

add log

7eec615

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Try to enable MariaDB in CI #36049

Try to enable MariaDB in CI #36049

nicosomb commented Apr 29, 2024

prestonBot commented Apr 29, 2024

grooverdan left a comment

grooverdan Apr 29, 2024

nicosomb Apr 30, 2024

grooverdan commented May 1, 2024

nicosomb commented May 2, 2024

grooverdan commented May 2, 2024

Try to enable MariaDB in CI #36049

Are you sure you want to change the base?

Try to enable MariaDB in CI #36049

Conversation

nicosomb commented Apr 29, 2024

prestonBot commented Apr 29, 2024

grooverdan left a comment

Choose a reason for hiding this comment

grooverdan Apr 29, 2024

Choose a reason for hiding this comment

nicosomb Apr 30, 2024

Choose a reason for hiding this comment

grooverdan commented May 1, 2024

nicosomb commented May 2, 2024

grooverdan commented May 2, 2024