[Migration Carrier pages] CQRS for Add / Get / Update / Upload logo #36063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boherm
added
Carriers
jolelievre
reviewed
May 2, 2024
There was a problem hiding this comment.
Thanks @boherm
I added a lot of comments on the PR but many of them can be postponed in a later PRs, the current PR is already a very good start that could be merged early so we can start parellizing the job We can discuss what should and should not be fixed right now 😉
src/Adapter/Carrier/CommandHandler/DeleteCarrierLogoHandler.php
Outdated
Show resolved
Hide resolved
src/Adapter/Carrier/CommandHandler/DeleteCarrierLogoHandler.php
Outdated
Show resolved
Hide resolved
src/Adapter/Carrier/CommandHandler/UploadCarrierLogoHandler.php
Outdated
Show resolved
Hide resolved
src/Adapter/Carrier/QueryHandler/GetCarrierForEditingHandler.php
Outdated
Show resolved
Hide resolved
src/PrestaShopBundle/Resources/config/services/adapter/carrier.yml
Outdated
Show resolved
Hide resolved
tests/Integration/Behaviour/Features/Context/Domain/CarrierFeatureContext.php
Show resolved
Hide resolved
tests/Integration/Behaviour/Features/Context/Domain/CarrierFeatureContext.php
Outdated
Show resolved
Hide resolved
tests/Integration/Behaviour/Features/Context/Domain/CarrierFeatureContext.php
Show resolved
Hide resolved
tests/Integration/Behaviour/Features/Scenario/Carrier/carrier_management.feature
Show resolved
Hide resolved
boherm
force-pushed
the
carrier-pages/add-get-update-upload-cqrs
branch
from
8cc3709
to
d11abc6
Compare
boherm
force-pushed
the
carrier-pages/add-get-update-upload-cqrs
branch
from
d11abc6
to
50b75e4
Compare
jolelievre
reviewed
May 20, 2024
tests/Integration/Behaviour/Features/Scenario/Carrier/carrier_management.feature
Show resolved
Hide resolved
boherm
force-pushed
the
carrier-pages/add-get-update-upload-cqrs
branch
from
50b75e4
to
fea88f1
Compare
jolelievre
reviewed
May 21, 2024
boherm
force-pushed
the
carrier-pages/add-get-update-upload-cqrs
branch
from
fea88f1
to
45f7fb2
Compare
boherm
force-pushed
the
carrier-pages/add-get-update-upload-cqrs
branch
from
45f7fb2
to
1bafd6d
Compare
tleon
approved these changes
May 22, 2024
ps-jarvis
added
the
Waiting for QA
|
This can't be tested by the QA team, the behat tests are enough for now. |
boherm
removed
the
Waiting for QA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #35925