Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error in PHP 8: count(): Argument #1 ($value) must be of type Countable|array, string given #36082

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

olecorre
Copy link
Contributor

@olecorre olecorre commented May 3, 2024

fix error in PHP 8: count(): Argument #1 ($value) must be of type Countable|array, string given

Questions Answers
Branch? develop
Description? fix error in PHP 8: count(): Argument #1 ($value) must be of type Countable
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? Save request SQL in BO with one jointure
UI Tests
Fixed issue or discussion? Fixes #36083
Related PRs
Sponsor company

fix error in PHP 8:  count(): Argument PrestaShop#1 ($value) must be of type Countable|array, string given
@olecorre olecorre requested a review from a team as a code owner May 3, 2024 09:29
@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added develop Branch Bug fix Type: Bug fix labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug fix Type: Bug fix develop Branch
Projects
Status: Ready for review
Development

Successfully merging this pull request may close these issues.

fix error in PHP 8: count(): Argument #1 ($value) must be of type Countable
4 participants