Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain differences between this repo and the corporate project #36088

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

fulldecent
Copy link
Contributor

To reduce confusion, improve transparency, and fairly introduce the other project

Questions Answers
Branch? develop
Description? Explain difference between this repository and the company product, which both have the same name and version numbers but are different products
Type? improvement
Category? FO / BO / CO / IN / WS / TE / LO / ME / PM
BC breaks? no
Deprecations? no
How to test? Read markdown file index.md
UI Tests not applicable
Fixed issue or discussion? Fixes #36055
Related PRs none
Sponsor company William Entriken, Pacific Medical Training

To reduce confusion, improve transparency, and fairly introduce the other project
@fulldecent fulldecent requested a review from a team as a code owner May 3, 2024 17:18
@prestonBot
Copy link
Collaborator

Hello @fulldecent!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • The category should be one of these: BO, CO, FO, IN, LO, ME, PM, TE or WS (Read explanation)

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels May 3, 2024
Hlavtox
Hlavtox previously approved these changes May 3, 2024
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry but

  • the content listed here is not accurate
  • I am against putting this in the README

This README is the README of prestashop/prestashop which is a software project. For the OSS project stuff we have https://www.prestashop-project.org/ which was created for this purpose.

I prefer to keep things in the right place 😉 and not mix them

@ps-jarvis ps-jarvis added the Waiting for author Status: action required, waiting for author feedback label May 3, 2024
@fulldecent
Copy link
Contributor Author

Thank you for your review, @matks. Can you please justify

the content listed here is not accurate

?


Surely there will be some confusion between the PrestaShop 8.1.5 product released in this repository and the PrestaShop 8.1.5 product released on PrestaShop.com.

If there is a more correct way to explain what I have tried in this PR, please give me a another chance to correct the errors and propose how we can transparently and constructively explain this in our README here.

@prestashop-issue-bot prestashop-issue-bot bot removed the Waiting for author Status: action required, waiting for author feedback label May 3, 2024
@matks
Copy link
Contributor

matks commented May 3, 2024

@fulldecent Long story short, PrestaShop project and PrestaShop company have been the entity for around ten years, a differenciation was initiated in 2022 but there are plenty things who are still merged.

For example the brand PrestaShop is solely owned by PrestaShop SA.

I'm sorry the only accurate answer 😅 is "it's complicated". If I had to go through each item (the brand, the software, the website, the policy...) I would need to write a hundred line statement.

Another example: every tool or service being used to carry out the project (GitHub, DockerHub, Crowding) are being paid by PrestaShop SA but their usage is made available to all project members.

Also some services like https://api.prestashop-project.org/ are being deployed by PrestaShop SA team although the code is open https://github.com/PrestaShop/distribution-api

I checked your website 😉 and I see you come from the blockchain world where I think things are 100% clear and un-ambiguous. I'm sorry I'm afraid for PrestaShop things are not as clear as they are for ETH for example.

(I anticipate more questions, I'm going on holidays this evening and I won't answer for around 10 days 😄 so if you don't get another answer from me in the next days it's not I'm ignoring you, just enjoying my vacations)

@matks
Copy link
Contributor

matks commented May 3, 2024

That being said I really prefer we keep the README for the software project and bring that kind of content in https://www.prestashop-project.org/ 😉

@fulldecent
Copy link
Contributor Author

Thank you, have a great vacation!

Yes you are right, before that I was at Google and worked on Linux 👋.

Updated PR to greatly simplify things. Hopefully it now says only the necessary things that people will need to know.

@Hlavtox
Copy link
Contributor

Hlavtox commented May 3, 2024

@matks I think the current version is alright. :-)

There are endless issues regarding this, if this clears it up for some of the poeple, it's at least something.

@nicosomb nicosomb requested a review from kpodemski May 4, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch Improvement Type: Improvement
Projects
Status: Waiting for author
Development

Successfully merging this pull request may close these issues.

Zipball on GitHub does not match website
5 participants