Add new "Check the label 'Needs autoupgrade PR'" workflow #36100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
M0rgan01
commented
May 6, 2024
•
M0rgan01
commented
| Questions | Answers |
|---|---|
| Branch? | develop |
| Description? | Added a new workflow to automatically add the "needs autoupgrade PR" label to know if a modification of the database structure has been detected. The workflow allows you to remove the label automatically if not necessary. The process is very fast (less than 2 mins) and is not blocking an PR. This is to inform contributors as well as reviewers that a PR will have to be made on the autoupgrade module. |
| Type? | improvement |
| Category? | PM |
| BC breaks? | no |
| Deprecations? | no |
| How to test? | Create a branch from it, make modifications to the database structure (db_structure.sql file or entities) and create a PR to the starting branch to trigger the CI (example here M0rgan01#14) |
| UI Tests | - |
| Fixed issue or discussion? | - |
| Related PRs | - |
| Sponsor company | - |
M0rgan01
force-pushed
the
add_autoupgrade_CI_steps
branch
from
28af954
to
0c31fc3
Compare
ga-devfront
previously approved these changes
May 6, 2024
Comment on lines
9
to
38
| name: Install Prestashop and create database dump for base branch | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Docker build | ||
| run: docker compose build prestashop-git | ||
|
|
||
| - name: Build dependency | ||
| run: docker compose run --rm prestashop-git composer install --ansi --prefer-dist --no-interaction --no-progress | ||
|
|
||
| - name: Create base database | ||
| run: docker compose run --rm mysql mysql -hmysql -uroot -pprestashop -e "CREATE DATABASE presta_base;" | ||
|
|
||
| - name: Install shop | ||
| run: docker compose run --rm prestashop-git php install-dev/index_cli.php \ | ||
| --step=database --db_server=mysql:3306 --db_name=presta_base --db_user=root --db_password=prestashop --prefix=ps_ --db_clear=1 \ | ||
| --domain=localhost:8001 --firstname="Marc" --lastname="Beier" \ | ||
| --password=Toto123! --email=demo@prestashop.com --language=fr --country=fr \ | ||
| --newsletter=0 --send_email=0 --ssl=0 | ||
|
|
||
| - name: Export dump | ||
| run: docker compose run --rm mysql sh -c "exec mysqldump -hmysql -uroot --no-data --compact -pprestashop presta_base" > dump_base.sql | ||
|
|
||
| - name: Upload dump | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: dump_base | ||
| path: | | ||
| dump_base.sql |
There was a problem hiding this comment.
I think we can refacto this part to not duplicate it and juste use reusable workflow with params. What do you think ?
There was a problem hiding this comment.
Are you thinking of a matrix ? totally possible
There was a problem hiding this comment.
I thought about using an action at first, but I guess a matrix would probably do the job better
There was a problem hiding this comment.
Although I wouldn't block the PR just for this so it's up to you
nicosomb
previously approved these changes
May 6, 2024
M0rgan01
dismissed stale reviews from jolelievre, nicosomb, and ga-devfront
via
b4388dd
M0rgan01
force-pushed
the
add_autoupgrade_CI_steps
branch
2 times, most recently
from
b4388dd
to
c88d864
Compare
M0rgan01
force-pushed
the
add_autoupgrade_CI_steps
branch
4 times, most recently
from
6c68fcc
to
d8b5240
Compare
nicosomb
previously approved these changes
May 7, 2024
M0rgan01
force-pushed
the
add_autoupgrade_CI_steps
branch
from
d8b5240
to
2efab66
Compare
M0rgan01
force-pushed
the
add_autoupgrade_CI_steps
branch
2 times, most recently
from
34c97eb
to
da81440
Compare
M0rgan01
force-pushed
the
add_autoupgrade_CI_steps
branch
from
da81440
to
e012f45
Compare
Quetzacoalt91
approved these changes
May 7, 2024
ps-jarvis
added
the
Waiting for QA
M0rgan01
removed
the
Waiting for QA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.