Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "brand" as column heading #36118

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

fulldecent
Copy link
Contributor

Questions Answers
Branch? develop
Description? This fixes the example import file products_example.csv to use the format expected during import process
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? Access the product import page (admin.../index.php?controller=AdminImport&token=...), download the example product file, import that file
UI Tests
Fixed issue or discussion? Progress on #36117, related to https://github.com/PrestaShop/PrestaShop/discussions/ {discussion number here} but does not completely fix them
Related PRs None

@fulldecent fulldecent requested a review from a team as a code owner May 8, 2024 14:50
@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added develop Branch Bug fix Type: Bug fix labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug fix Type: Bug fix develop Branch
Projects
Status: Ready for review
Development

Successfully merging this pull request may close these issues.

None yet

2 participants