Error 500 fix for Admin Categories If description null (backport from develop) #36122
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ShaiMagal
commented
May 9, 2024
•
ShaiMagal
commented
| Questions | Answers |
|---|---|
| Branch? | 8.1.x |
| Description? | Error fix for stripslashes(): Argument #1 ($string) must be of type string, null given. The parameter is null after migration. Please can we use the if condition and check if it's not null? Because if it is null gives a 500 error. ORIGINAL IDEA BY @uguranium - we should backport it to 8.1.x branch, because it's very common problem, so 8.1. customers must benefit from this fix as well, not in develop, but now. |
| Type? | bug fix |
| Category? | BO |
| BC breaks? | no |
| Deprecations? | no |
| How to test? | |
| UI Tests | https://github.com/nicosomb/ga.tests.ui.pr/actions/runs/9032410643 |
| Fixed issue or discussion? | |
| Related PRs | #30922 |
| Sponsor company | https://www.openservis.cz/ |
ShaiMagal
changed the title
Hlavtox
approved these changes
May 9, 2024
nicosomb
approved these changes
May 10, 2024
ps-jarvis
added
the
Waiting for QA
matthieu-rolland
approved these changes
May 13, 2024
|
Ping @PrestaShop/prestashop-core-developers : QA by dev please, it's to technical. Can be tested like #30922 I think. Thanks in advance! |
paulnoelcholot
added
the
Waiting for dev
boherm
approved these changes
May 15, 2024
kpodemski
approved these changes
May 15, 2024
kpodemski
removed
Waiting for QA
|
thank you @ShaiMagal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.