Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of OpenQASM 3.0 standard library #12387

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jakelishman
Copy link
Member

Summary

This is just a file vendored from the OpenQASM project, but it's been updated since the last time we vendored it to fix a couple of problems. This one is vendored from openqasm/openqasm@4ca1d793833b24a1.

Details and comments

Close #12167

Actually that issue was about something a little different, but this is the only remnant bit that needs addressing from Qiskit.

This is just a file vendored from the OpenQASM project, but it's been
updated since the last time we vendored it to fix a couple of problems.
This one is vendored from openqasm/openqasm@4ca1d793833b24a1.
@jakelishman jakelishman added Changelog: New Feature Include in the "Added" section of the changelog mod: qasm3 Related to OpenQASM 3 import or export labels May 10, 2024
@jakelishman jakelishman added this to the 1.2.0 milestone May 10, 2024
@jakelishman jakelishman requested a review from a team as a code owner May 10, 2024 13:45
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9033180578

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 89.648%

Files with Coverage Reduction New Missed Lines %
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 2 88.2%
crates/qasm2/src/lex.rs 3 92.62%
Totals Coverage Status
Change from base Build 9032084393: 0.02%
Covered Lines: 62215
Relevant Lines: 69399

💛 - Coveralls

raynelfss

This comment was marked as duplicate.

Copy link
Contributor

@raynelfss raynelfss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a quick question about the link at the beginning of the file.

// OpenQASM 3.0 standard gate library
//
// Vendored from the OpenQASM 3.0 project at
// https://github.com/openqasm/openqasm.git@4ca1d793833b24a1.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right link? It leads to a Not Found message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the "Added" section of the changelog mod: qasm3 Related to OpenQASM 3 import or export
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange Behaviour of sx gate when defined inline in QASM
4 participants