Add QuickLint, a CLI tool to detect focused specs, and optionally remove the focus. #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
Apparently, to ship a binary with cocoapods, you have to actually build it yourself and then include that. Which is not something I'm interested in doing at the moment. |
|
Lol, on Xcode 15.3, command plugins just... disappear after the first time you run them.
|
…ocused specs are identified Remove xcode command plugins, because they don't work. Add tests to verify that defocus and lint commands work when given the exact files to lint
… and error is set.
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
May 12, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [Quick/Quick](https://togithub.com/Quick/Quick) | minor | `from: "7.5.0"` -> `from: "7.6.0"` | --- ### Release Notes <details> <summary>Quick/Quick (Quick/Quick)</summary> ### [`v7.6.0`](https://togithub.com/Quick/Quick/releases/tag/v7.6.0): 7.6.0 - QuickLint [Compare Source](https://togithub.com/Quick/Quick/compare/v7.5.0...v7.6.0) ### Highlights - Add QuickLint, a CLI tool & Xcode plugin to detect focus specs and remove the focus. - Async DSL: Marks the async version of `sharedExamples` as unavailable. Previously, `sharedExamples` would just not be found, and this clarifies that `sharedExamples` is intentionally unavailable in the async DSL. ### Automated Changelog #### What's Changed - Bump rake from 13.1.0 to 13.2.1 by [@​dependabot](https://togithub.com/dependabot) in [Quick/Quick#1281 - named the context param aContext to match the actual protocol by [@​Noobish1](https://togithub.com/Noobish1) in [Quick/Quick#1283 - Add QuickLint, a CLI tool to detect focused specs, and optionally remove the focus. by [@​younata](https://togithub.com/younata) in [Quick/Quick#1280 #### New Contributors - [@​Noobish1](https://togithub.com/Noobish1) made their first contribution in [Quick/Quick#1283 **Full Changelog**: Quick/Quick@v7.5.0...v7.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oftentimes, teams who use Quick's spec focusing either have to be really diligent about removing focus, or write a script to check for focus (and either block the push, or fail CI). Usually the latter is chosen. In an effort to alleviate writing those scripts, I wrote QuickLint. Which detects focused specs in the current directory, and also allows you to defocus the specs.
QuickLint also serves as an example of how to write testable code, and how to use Quick, Nimble, and the new Swift Fakes packages.
Upcoming in this PR are also build tool and command plugins (for SwiftPM and Xcode) to lint and defocus your specs.
New feature, doesn't break the public API. So... minor version bump!