Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

named the context param aContext to match the actual protocol #1283

Merged
merged 2 commits into from May 11, 2024

Conversation

Noobish1
Copy link
Contributor

@Noobish1 Noobish1 commented May 6, 2024

Hi there, in the SharedExamples docs, the use of the Behavior class is slightly incorrect in that it names the context param context instead of aContext like the class itself. This has the nasty consequence of shadowing any use of context blocks within the spec func.

Copy link
Member

@younata younata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks!

Documentation/en-us/SharedExamples.md Outdated Show resolved Hide resolved
@younata younata merged commit 46c0056 into Quick:main May 11, 2024
12 checks passed
cgrindel-self-hosted-renovate bot added a commit to cgrindel/rules_swift_package_manager that referenced this pull request May 12, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [Quick/Quick](https://togithub.com/Quick/Quick) | minor | `from:
"7.5.0"` -> `from: "7.6.0"` |

---

### Release Notes

<details>
<summary>Quick/Quick (Quick/Quick)</summary>

### [`v7.6.0`](https://togithub.com/Quick/Quick/releases/tag/v7.6.0):
7.6.0 - QuickLint

[Compare
Source](https://togithub.com/Quick/Quick/compare/v7.5.0...v7.6.0)

### Highlights

- Add QuickLint, a CLI tool & Xcode plugin to detect focus specs and
remove the focus.
- Async DSL: Marks the async version of `sharedExamples` as unavailable.
Previously, `sharedExamples` would just not be found, and this clarifies
that `sharedExamples` is intentionally unavailable in the async DSL.

### Automated Changelog

#### What's Changed

- Bump rake from 13.1.0 to 13.2.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[Quick/Quick#1281
- named the context param aContext to match the actual protocol by
[@&#8203;Noobish1](https://togithub.com/Noobish1) in
[Quick/Quick#1283
- Add QuickLint, a CLI tool to detect focused specs, and optionally
remove the focus. by [@&#8203;younata](https://togithub.com/younata) in
[Quick/Quick#1280

#### New Contributors

- [@&#8203;Noobish1](https://togithub.com/Noobish1) made their first
contribution in
[Quick/Quick#1283

**Full Changelog**:
Quick/Quick@v7.5.0...v7.6.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants