Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added lowercased candidates comparison, Damerau distance, Bayesian re… #91

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fingoldo
Copy link

…asoning, GPU inference. Exposed top_n candidates parameter instead of the hardcoded number.

Description

  • Issue this PR address?
  • Any other information you think is relevant

Checklist

  • Added and/or updated the test (not required for documentation changes)
  • My changes don't require a change to the documentation, or if they do, I've added all required information

…asoning, GPU inference. Exposed top_n candidates parameter instead of the hardcoded number.
@stale
Copy link

stale bot commented Sep 16, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix This will not be worked on label Sep 16, 2023
@R1j1t R1j1t removed the wontfix This will not be worked on label Sep 25, 2023
@R1j1t R1j1t self-requested a review September 25, 2023 14:00
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
contextualSpellCheck/contextualSpellCheck.py Outdated Show resolved Hide resolved
contextualSpellCheck/contextualSpellCheck.py Show resolved Hide resolved
@R1j1t
Copy link
Owner

R1j1t commented Sep 28, 2023

Can you also rebase your branch to pull some recent changes?

@R1j1t
Copy link
Owner

R1j1t commented Oct 2, 2023

I have fixed the test pipelines, so post rebase with main the pipeline can check for current behavior. I would like to contribute to your branch, so please let me know if there is any change I can own.

@fingoldo
Copy link
Author

fingoldo commented Oct 2, 2023

I have fixed the test pipelines, so post rebase with main the pipeline can check for current behavior. I would like to contribute to your branch, so please let me know if there is any change I can own.

Sure, but I'm not very experienced with git. How exactly should I proceed?

@R1j1t
Copy link
Owner

R1j1t commented Oct 2, 2023

No worries, can you try to follow: https://stackoverflow.com/a/54036195/7630458?
The idea is to incorporate recently merged changes to your PR as well.

@fingoldo
Copy link
Author

Sorry for the delay, I think I did what's needed, could you check, please?

Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix This will not be worked on label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants