refactor!: rename socials to connections
#142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: validcube <pun.butrach@gmail.com>
|
This is a breaking change, meaning you can't push this change to /v2/ And seeing that it's not particularly a necessary change either, the PR may be better off closed in my opinion, the issue should be updated to target v3 milestone |
validcube
changed the title
socials to connectionssocials to connections
|
In the # API Versioning
api_versions: dict[str, list[str]] = {
"old": ["compat"],
"v2": [
"announcements",
"donations",
"github",
"info",
"login",
"ping",
"socials",
"manager",
],
"v3": [
"announcements",
"donations",
"github",
"info",
"login",
"ping",
"connections",
"manager",
]
}The API lacks a straightforward way to provide multiple versions of the same endpoint atm, I am working on that for the next feature pack. |
alexandreteles
added
modification
👍 Done |
romiks28
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't update Qodana because I have no idea how to use it... well I do know how to use it but I ran into issue with performance
fix #106