Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Old language remains in settings tab after switching language #1731

Open
4 tasks done
KobeW50 opened this issue Mar 5, 2024 · 1 comment
Open
4 tasks done

bug: Old language remains in settings tab after switching language #1731

KobeW50 opened this issue Mar 5, 2024 · 1 comment
Assignees
Labels
Bug report Something isn't working

Comments

@KobeW50
Copy link
Contributor

KobeW50 commented Mar 5, 2024

Bug description

When you change the language, all but one of the strings in the settings tab will remain in the old language until you switch to the patcher or dashboard tab (and then return to the settings tab).

Steps to reproduce

  1. Set the language of the Manager to English.
  2. Fully close and restart the Manager.
  3. Set the language to any language other than English and press "OK".

(You will now be in the settings tab but only the widget for language selection will be in the newly selected language.)

  1. Switch to the patcher or dashboard tab.
  2. Switch back to the settings tab.

(Now all of the widgets with strings in the new language will be in the new language.)

Screen_Recording_20240304_220620_ReVanced_Manager.mp4

Version of ReVanced Manager and version & name of app you are patching

1.19.1

Installation method

None

ReVanced Manager logs

revanced-manager_logcat_20240304220102205740.log.txt

Patch logs

No response

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • The bug is only related to ReVanced Manager
@KobeW50 KobeW50 added the Bug report Something isn't working label Mar 5, 2024
@validcube
Copy link
Member

validcube commented Mar 5, 2024

We would only need to reload the page every time the language changed, this should be a very easy fix. (I HOPE)

I have noticed this issue since the feature was introduced, but I forgot to file it. :trollface: Whoops, too late for this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants