fix(ui): Support free-scroll and auto-scroll for the installer logs (#1736) #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhances the installer log functionality by adding dynamic autoscroll behavior. The scroll listens for user's pan interactions, allowing for intelligent autoscroll control. Users can detach autoscroll by dragging out or holding, and reattach the tail (follow) by clicking the "go to bottom" FAB button or scrolling to the bottom, similar to Discord's behavior. This enhancement greatly improves user experience during installation processes.
This commit fixes the issue where the auto scroll button toggles immediately after scrolling even when it's within the anchor point, by updating the auto scroll button visibility only after the user stops interacting with the scroll.
|
🙏 I can safely retire now |
validcube
requested review from
validcube and
BenjaminHalko
and removed request for
BenjaminHalko
Domenic-MZS
changed the title
|
🥞 LGTM!
Additional note: Your PR is approved by me. |
validcube
changed the title
validcube
approved these changes
Apr 4, 2024
|
Wow, that was blazingly fast 🔥 thanks @oSumAtrIX, @validcube, and @BenjaminHalko !! |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 5, 2024
# [1.20.0](v1.19.3...v1.20.0) (2024-04-05) ### Bug Fixes * disable proguard obfuscation ([401646a](401646a)) * Do not crash when selecting an APK from storage ([#1768](#1768)) ([8564c1a](8564c1a)) * Don't translation ReVanced repository ([c265794](c265794)) * Ensure safe area usage in Changelogs Modal Bottom Sheet ([#1772](#1772)) ([c981cb4](c981cb4)) * Pre-releases changelog being shown ([#1767](#1767)) ([add49e1](add49e1)) * Replace Spacer with Expanded to avoid overflow ([#1791](#1791)) ([6f70a07](6f70a07)) * Set text colour on dropdown menu for Custom Value ([966796d](966796d)), closes [#1584](#1584) * **ui:** Support free-scroll and auto-scroll for the installer logs ([#1736](#1736)) ([#1836](#1836)) ([025ff52](025ff52)) ### Features * Improve language update settings ([#1838](#1838)) ([f9e6ef3](f9e6ef3))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧🎨 UI Fix: Enhance Installer Logs Autoscroll Feature (#1736)
This PR fixes #1736, reported by @KobeW50
Overview
The installer logs' functionality has been enhanced by introducing a dynamic auto-scroll feature, Allowing free scrolling when the user pans the scroll. However, if the user scrolls down to the bottom or hits the auto-scroll-button it will lock in-place again improving the user experience/curiosity during the installation processes.
📓 Description
This PR introduces dynamic autoscroll behavior to the installer logs. The autoscroll feature listens for user pan interactions, allowing for intelligent autoscroll control/toggle. Users can detach autoscroll by start dragging out or holding, and it can reattach the tail (follow) by clicking the "go to bottom" FAB button or manually scrolling to the bottom (anchor point sweet point at
95%).✍🏼 Changes Made
Technical overview
_isAutoScrollEnabled: flag to automatically call scroll to bottom on incoming data_isAutoScrolling: flag to lock the current scroll configuration like a loading or busy state until scrolledshowAutoScrollButton: flag to render the Scroll to bottom FAB button on the stacked screen🦯 Testing
Update Tests (ToDo - Not Found nor needed for now...)Stable Flutter v3.19.3anddart 3.3.1.📋 Notes & References
🔬 Reviewers
N/A (any mod is ok)
👾 Feedback, changes, or suggestions are welcome! ✌🏼 🏖️ now a 🍕 emoji too...