Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add warning when installing if any patching errors occured #1737

Open
3 tasks done
KobeW50 opened this issue Mar 5, 2024 · 0 comments
Open
3 tasks done

feat: Add warning when installing if any patching errors occured #1737

KobeW50 opened this issue Mar 5, 2024 · 0 comments
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@KobeW50
Copy link
Contributor

KobeW50 commented Mar 5, 2024

Feature description

If a patch fails or errors (but patching doesn't abort), the manager should warn the user about it when the user tries to install or export the APK.

One of the buttons on the popup should copy the patch logs. And, if possible, the warning popup should specify which patches failed.

(Note that some patching errors aren't related to patches, but rather regarding the APK, (de)compiling, etc. These miscellaneous errors also need to be addressed in the dialog.)

Motivation

  1. I see so many users on Discord and Reddit who don't realize that patching errors occured.

  2. When a user doesn't realize a patching error occured, they may be missing a critical patch (such as GmsCore support in the case of YT and YT Music). Even for non-critical patches, the user should be notified that a patch which they selected couldn't be applied.

  3. When a patching error occurs, it may cause the installed app to crash or have bugs. This warning will prevent this from occurring in many cases, or at least give the user a hint as to why their patched app is crashing/buggy.

Acknowledgements

  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • The feature request is only related to ReVanced Manager
@KobeW50 KobeW50 added the Feature request Requesting a new feature that's not implemented yet label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

1 participant