Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Slight clipping in Alternative sources setting #1748

Open
4 tasks done
ILoveOpenSourceApplications opened this issue Mar 6, 2024 · 4 comments · May be fixed by #1782
Open
4 tasks done

bug: Slight clipping in Alternative sources setting #1748

ILoveOpenSourceApplications opened this issue Mar 6, 2024 · 4 comments · May be fixed by #1782
Labels
Bug report Something isn't working

Comments

@ILoveOpenSourceApplications

Bug description

If the user is typing or editing the value and has their keyboard open in the Patches organization box, the title clips into the padding.
Screenshot_20240306_153035_ReVanced Manager

Version of ReVanced Manager and version & name of app you are patching

v1.19.1

Installation method

Regular

ReVanced Manager logs

Nil

Patch logs

No response

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • The bug is only related to ReVanced Manager
@ILoveOpenSourceApplications ILoveOpenSourceApplications added the Bug report Something isn't working label Mar 6, 2024
@oSumAtrIX
Copy link
Member

The clipping does not occur for me.

@ILoveOpenSourceApplications
Copy link
Author

How's it showing up for you? Can you share a screen shot?

@oSumAtrIX
Copy link
Member

I am now able to reproduce when opening the keyboard, previously I had the keyboard closed, mb

@Domenic-MZS
Copy link
Contributor

Domenic-MZS commented Mar 23, 2024

Seems like a clipping issue of the Dialog (Widget) having a nested SingleChildScrollView (Widget) thing... It'll be fixed if the parent (Dialog) handles the scroll and not the child (SingleChildScrollView).

Lemme fix this real quick 😀

EDIT: 👾 Despite how it sounds, these changes should maintain the same effect and look alike the current implementation (without the clipping and extra scroll, though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
3 participants