bug: GitHub ratelimit unhandled

[ILoveOpenSourceApplications]

Bug description

If alternative source is toggled on/off once, the manager goes into this unresponsive state where none of the patchable apps load, and if a patchable app is selected, none of the patches load either. And the changeling also stops working as it showing a loading circle instead.

807fbe11-e595-4b12-9d8d-d8e4ecec5d3d.2.mp4

PS: #1760 can be clubbed with this issue.

Version of ReVanced Manager and version & name of app you are patching

v1.19.3

Installation method

None

ReVanced Manager logs

Nil

Patch logs

No response

Acknowledgements

• This issue is not a duplicate of an existing bug report.
• I have chosen an appropriate title.
• All requested information has been provided properly.
• The bug is only related to ReVanced Manager

[oSumAtrIX]

Are you rate limited on GitHub? https://api.github.com/rate_limit

[ILoveOpenSourceApplications]

{"resources":{"core":{"limit":60,"remaining":2,"reset":1711061079,"used":58,"resource":"core"},"graphql":{"limit":0,"remaining":0,"reset":1711061595,"used":0,"resource":"graphql"},"integration_manifest":{"limit":5000,"remaining":5000,"reset":1711061595,"used":0,"resource":"integration_manifest"},"search":{"limit":10,"remaining":10,"reset":1711058055,"used":0,"resource":"search"}},"rate":{"limit":60,"remaining":2,"reset":1711061079,"used":58,"resource":"core"}}

[oSumAtrIX]

You seem rate-limited, but still, this is something ReVanced Manager should take care of.

[oSumAtrIX]

For support move to the links on https://revanced.app

[validcube]

👋 Hello, @ILoveOpenSourceApplications!

Quick status update here, Unfortunately I will have to unassign myself from this issue (and any other issue that I've assigned to) as tomorrow is the day where I will became unavailable for the rest of the month for unspecified reason (for team refer to recreated janky excel file in the email that I've sent about weeks ago).

🔧 For anyone who's going to work on this

From a quick glance at this issue we would need some kind of interceptor to check if GitHub reply with 429 HTTP-code or check for x-ratelimit-remaining HTTP header. If limit is reached we would likely inform the user about the rate-limit problem and tell them to try later (and/or inform them about the reset time: x-ratelimit-reset header).

Feel free to deviate from this plan if you feel like you have a better solution.

• https://docs.github.com/en/rest/using-the-rest-api/rate-limits-for-the-rest-api?apiVersion=2022-11-28#exceeding-the-rate-limit

[ILoveOpenSourceApplications]

Feel free to deviate from this plan if you feel like you have a better solution.

Hi, @validcube. Nope, I don't have any better solution. Though due to this issue, at times when I'm trying to patch, the manager becomes basically unresponsive and buffers and or doesn't load anything required. Switching between WiFi and mobile network seems to help at times.

[ILoveOpenSourceApplications]

This is just my doubt, but this issue began only after the introduction of changelogs into the manager. And everytime I open the manager and tap on the changelogs button, I noticed that it's fetching real time data from the internet (from the buffering). Could this also be one of the reason why the GitHub rate limit is getting exceeded as the manager now accesses the github api for fetching the changelogs for both the manager and patches as well as fetching the patch & integration data for patching as well?

If so, then making the manager remember the last changelog until an update is done to either would be better in handling the traffic right?