bug: Crashes upon pressing the "patch" button on Android 14

[dwitterer]

Bug description

I can launch ReVanced Manager, navigate to any of the screens, and get all the way to the point of selecting which patches to apply, but then whenever I press 'Patch', the app immediately crashes and I get a pop-up that 'ReVanced Manager keeps crashing'. Rebooting, re-installing the Manager and patches, and switching to ReVanced GMSCore did not fix the issue. The Manager dashboard also always says that my patcher was last updated 26 days ago, which is not true - unsure of this is relevant. Logs attached below.

Version of ReVanced Manager and version & name of app you are patching

ReVanced Manager 1.19.4-dev.5, release build (but earlier versions such as 1.19.3 also do the same thing)
Android 14, OneUI 6.1 (Samsung S22 Ultra)
Patches 4.6.0
Trying to patch YouTube 19.09.37

Installation method

None

ReVanced Manager logs

[...]
04-04 21:58:38.969 12718 12744 W vulkan  : CreateSwapchainKHR(VkSwapchainCreateInfoKHR.imageColorSpace = 1000104013) failed: Unsupported color space, but assume as Success for ANGLE.
04-04 21:58:38.971 12718 12718 I SurfaceView: 162898386 surfaceChanged -- format=4 w=1440 h=3088
04-04 21:58:38.971 12718 12718 I SurfaceView@9b5a1d2: surfaceChanged (1440,3088) 1 #8 io.flutter.embedding.android.m{9b5a1d2 V.E...... ......ID 0,0-1440,3088}
04-04 21:58:38.971 12718 12718 I SurfaceView: 162898386 surfaceRedrawNeeded
04-04 21:58:38.971 12718 12718 I SurfaceView: 162898386 finishedDrawing
04-04 21:58:38.971 12718 12718 V SurfaceView@9b5a1d2: Layout: x=0 y=0 w=1440 h=3088, frame=Rect(0, 0 - 1440, 3088)
04-04 21:58:39.307 12718 12718 D InsetsSourceConsumer: applyRequestedVisibilityToControl: visible=true, type=1
04-04 21:58:39.308 12718 12718 D InsetsSourceConsumer: applyRequestedVisibilityToControl: visible=true, type=2
04-04 21:58:39.647 12718 12743 I flutter : dynamic_color: Core palette detected.
04-04 21:58:39.649 12718 12744 I manager.flutter: [HIDL_FETCH_IMapper] android.hardware.graphics.mapper@4.0: Loaded Mapper successfully.
04-04 21:58:39.654 12718 12744 I blob    : initializing random seed using 18397754039491
04-04 21:58:39.655 12718 12744 I blob    : get: caller's buffer is too small for value: 0 (needs 20483)
04-04 21:58:39.655 12718 12744 I blob    : get: copying 20483 bytes to caller's buffer
04-04 21:58:39.655 12718 12744 I blob    : get: caller's buffer is too small for value: 0 (needs 20483)
04-04 21:58:39.655 12718 12744 I blob    : get: copying 20483 bytes to caller's buffer
04-04 21:58:39.662 12718 12744 I BLASTBufferQueue: [SurfaceView[app.revanced.manager.flutter/app.revanced.manager.flutter.MainActivity]@0#1](f:0,a:0,s:0) onFrameAvailable the first frame is available
04-04 21:58:39.972 12718 12718 D SurfaceView@9b5a1d2: 162898386 setAlpha: alpha=1.0
04-04 21:58:39.972 12718 12718 I SurfaceView: 162898386 Changes: creating=false format=false size=false visible=false alpha=true hint=false visible=false left=false top=false z=false attached=true lifecycleStrategy=false
04-04 21:58:39.972 12718 12718 I SurfaceView@9b5a1d2: 162898386 Cur surface: Surface(name=null)/@0x267fef4
04-04 21:58:39.972 12718 12718 I SurfaceView@9b5a1d2: updateSurface: mVisible = true mSurface.isValid() = true
04-04 21:58:39.972 12718 12718 I SurfaceView@9b5a1d2: updateSurface: mSurfaceCreated = true surfaceChanged = false visibleChanged = false
04-04 21:58:39.972 12718 12718 I SurfaceView: 162898386 surfaceRedrawNeeded
04-04 21:58:39.973 12718 12718 I SurfaceView: 162898386 finishedDrawing
04-04 21:58:39.973 12718 12718 V SurfaceView@9b5a1d2: Layout: x=0 y=0 w=1440 h=3088, frame=Rect(0, 0 - 1440, 3088)
04-04 21:58:39.977 12718 12718 I BLASTBufferQueue_Java: update, w= 1440 h= 3088 mName = ViewRootImpl@980dad0[MainActivity] mNativeObject= 0xb400006e4329dcd0 sc.mNativeObject= 0xb400006e1329b610 format= -3 caller= android.view.ViewRootImpl.updateBlastSurfaceIfNeeded:2968 android.view.ViewRootImpl.relayoutWindow:9998 android.view.ViewRootImpl.performTraversals:4056 android.view.ViewRootImpl.doTraversal:3239 android.view.ViewRootImpl$TraversalRunnable.run:11197 android.view.Choreographer$CallbackRecord.run:1650 
04-04 21:58:39.977 12718 12718 I ViewRootImpl@980dad0[MainActivity]: Relayout returned: old=(0,0,1440,3088) new=(0,0,1440,3088) req=(1440,3088)0 dur=2 res=0x401 s={true 0xb400006e532b9d70} ch=false seqId=0
04-04 21:58:39.977 12718 12718 D ViewRootImpl@980dad0[MainActivity]: reportNextDraw android.view.ViewRootImpl.performTraversals:4658 android.view.ViewRootImpl.doTraversal:3239 android.view.ViewRootImpl$TraversalRunnable.run:11197 android.view.Choreographer$CallbackRecord.run:1650 android.view.Choreographer$CallbackRecord.run:1659 
04-04 21:58:39.978 12718 12718 D ViewRootImpl@980dad0[MainActivity]: Setup new sync=wmsSync-ViewRootImpl@980dad0[MainActivity]#2
04-04 21:58:39.978 12718 12718 D ViewRootImpl@980dad0[MainActivity]: Creating new active sync group ViewRootImpl@980dad0[MainActivity]#3
04-04 21:58:39.979 12718 12718 D ViewRootImpl@980dad0[MainActivity]: registerCallbacksForSync syncBuffer=false
04-04 21:58:39.979 12718 12738 D SurfaceView: 162898386 updateSurfacePosition RenderWorker, frameNr = 1, position = [0, 0, 1440, 3088] surfaceSize = 1440x3088
04-04 21:58:39.980 12718 12738 I SurfaceView@9b5a1d2: uSP: rtp = Rect(0, 0 - 1440, 3088) rtsw = 1440 rtsh = 3088
04-04 21:58:39.980 12718 12738 I SurfaceView@9b5a1d2: onSSPAndSRT: pl = 0 pt = 0 sx = 1.0 sy = 1.0
04-04 21:58:39.980 12718 12738 I SurfaceView@9b5a1d2: aOrMT: ViewRootImpl@980dad0[MainActivity] t = android.view.SurfaceControl$Transaction@a98b6b1 fN = 1 android.view.SurfaceView.-$$Nest$mapplyOrMergeTransaction:0 android.view.SurfaceView$SurfaceViewPositionUpdateListener.positionChanged:1660 android.graphics.RenderNode$CompositePositionUpdateListener.positionChanged:369 
04-04 21:58:39.980 12718 12738 I ViewRootImpl@980dad0[MainActivity]: mWNT: t=0xb400006fd32b4750 mBlastBufferQueue=0xb400006e4329dcd0 fn= 1 caller= android.view.SurfaceView.applyOrMergeTransaction:1592 android.view.SurfaceView.-$$Nest$mapplyOrMergeTransaction:0 android.view.SurfaceView$SurfaceViewPositionUpdateListener.positionChanged:1660 
04-04 21:58:39.980 12718 13648 D ViewRootImpl@980dad0[MainActivity]: Received frameDrawingCallback syncResult=0 frameNum=1.
04-04 21:58:39.980 12718 13648 I ViewRootImpl@980dad0[MainActivity]: mWNT: t=0xb400006fd32c12d0 mBlastBufferQueue=0xb400006e4329dcd0 fn= 1 caller= android.view.ViewRootImpl$8.onFrameDraw:13614 android.view.ThreadedRenderer$1.onFrameDraw:788 <bottom of call stack> 
04-04 21:58:39.980 12718 13648 D ViewRootImpl@980dad0[MainActivity]: Setting up sync and frameCommitCallback
04-04 21:58:39.984 12718 12738 I BLASTBufferQueue: [ViewRootImpl@980dad0[MainActivity]#0](f:0,a:0,s:0) onFrameAvailable the first frame is available
04-04 21:58:39.985 12718 12738 D ViewRootImpl@980dad0[MainActivity]: Received frameCommittedCallback lastAttemptedDrawFrameNum=1 didProduceBuffer=true
04-04 21:58:39.985 12718 12738 D OpenGLRenderer: CFMS:: SetUp Pid : 12718    Tid : 12738
04-04 21:58:39.985 12718 12718 D ViewRootImpl@980dad0[MainActivity]: reportDrawFinished
04-04 21:58:40.148 12718 12718 I ViewRootImpl@980dad0[MainActivity]: registerCallbackForPendingTransactions
04-04 21:58:40.149 12718 12718 I ViewRootImpl@980dad0[MainActivity]: MSG_WINDOW_FOCUS_CHANGED 1 0
04-04 21:58:40.149 12718 12718 D ViewRootImpl@980dad0[MainActivity]: mThreadedRenderer.initializeIfNeeded()#2 mSurface={isValid=true 0xb400006e532b9d70}
04-04 21:58:40.149 12718 12718 D InputMethodManagerUtils: startInputInner - Id : 0
04-04 21:58:40.149 12718 12718 I InputMethodManager: startInputInner - IInputMethodManagerGlobalInvoker.startInputOrWindowGainedFocus
04-04 21:58:40.150 12718 13646 I ViewRootImpl@980dad0[MainActivity]: mWNT: t=0xb400006fd32c8230 mBlastBufferQueue=0xb400006e4329dcd0 fn= 2 caller= android.view.ViewRootImpl$6.onFrameDraw:5539 android.view.ViewRootImpl$2.onFrameDraw:2103 android.view.ThreadedRenderer$1.onFrameDraw:788 
04-04 21:58:40.157 12718 12718 D InputMethodManagerUtils: startInputInner - Id : 0
04-04 21:58:40.162 12718 12718 D InsetsSourceConsumer: applyRequestedVisibilityToControl: visible=false, type=8
04-04 21:58:40.864 12718 12718 I ViewRootImpl@980dad0[MainActivity]: ViewPostIme pointer 0
04-04 21:58:40.961 12718 12718 I ViewRootImpl@980dad0[MainActivity]: ViewPostIme pointer 1
04-04 21:58:40.991 12718 12718 W WindowOnBackDispatcher: OnBackInvokedCallback is not enabled for the application.
04-04 21:58:40.991 12718 12718 W WindowOnBackDispatcher: Set 'android:enableOnBackInvokedCallback="true"' in the application manifest.
04-04 21:58:41.776 12718 12718 I ViewRootImpl@980dad0[MainActivity]: ViewPostIme pointer 0
04-04 21:58:41.928 12718 12718 I ViewRootImpl@980dad0[MainActivity]: ViewPostIme pointer 1
04-04 21:58:43.006 12718 12718 I ViewRootImpl@980dad0[MainActivity]: ViewPostIme pointer 0
04-04 21:58:44.161 12718 12718 I ViewRootImpl@980dad0[MainActivity]: ViewPostIme pointer 1
04-04 21:58:44.622 12718 12718 I ViewRootImpl@980dad0[MainActivity]: ViewPostIme pointer 0
04-04 21:58:44.704 12718 12718 I ViewRootImpl@980dad0[MainActivity]: ViewPostIme pointer 1

Patch logs

No response

Acknowledgements

• This issue is not a duplicate of an existing bug report.
• I have chosen an appropriate title.
• All requested information has been provided properly.
• The bug is only related to ReVanced Manager

[oSumAtrIX]

Duplicate of #1839

[dwitterer]

revanced-manager_logcat_20240404215844706587.log

Full logs, though I only see a couple warnings..

[dwitterer]

Duplicate of #1839

Ah, I see... That issue didn't have logs though, so they're here if needed :) Also, this seems to happen on Manager version 1.19.3 also. Thanks.

[oSumAtrIX]

If it happens in the latest full release and crashes, you should be able to capture error logs using logcat | grep AndroidRuntime

[dwitterer]

Ah, no, it does work on 1.19.3... My bad. Sorry for the dupe :)