feat(Piccoma): Add Enable debugging patch
#3144
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oSumAtrIX
changed the title
Debug mode patchEnable debugging patch
oSumAtrIX
reviewed
May 18, 2024
|
|
||
| @Patch( | ||
| name = "Enable debugging", | ||
| description = "Enable every debug possibilities of the app.", |
There was a problem hiding this comment.
Please provide a better description of what this patch does. What kind of debugging is achieved?
There was a problem hiding this comment.
I would like your opinion on it, but I think I will split the patch in 3. One part for DEV mode, one part for logging HTTP requests by setting the DEBUG flag in volley and a last one for the rest. What do you think ?
oSumAtrIX
reviewed
May 18, 2024
| setOf(AppConfFingerprint, OpenToUserFingerprint), | ||
| ) { | ||
| override fun execute(context: BytecodeContext) { | ||
| AppConfFingerprint.result?.mutableMethod?.apply { |
There was a problem hiding this comment.
Please add a comment here explaining what each patch does. It is unclear what the instruction replacement is done for and what it effects. Add comments for the patches below as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.