feat(Reddit - Hide banner ads): Constrain to last working version #3156
Conversation
ascopes
force-pushed
the
bugfix/GH-3099-pin
branch
from
d900895
to
0395b78
Compare
Pinned until GH-3099 is addressed.
ascopes
force-pushed
the
bugfix/GH-3099-pin
branch
from
0395b78
to
95c6c68
Compare
|
Not part of this MR but possibly worth noting that the link to the docs explaining how to structure the commit naming seems to be broken, so the name of this commit is a bit of a stab in the dark on my behalf. Hopefully this is correct. |
src/main/kotlin/app/revanced/patches/reddit/ad/banner/HideBannerPatch.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Since this patch is a dependency and not usable in any frontend, it inherits the compatibility of the dependant patches. For that reason, the compatibility needs to be set on the patches which depend on this one. Alternatively, this patch can get a name & other patches can stop depend on it so that they can be used on later versions with this patch unselected.
oSumAtrIX
changed the title
|
If I go for the latter, is it just a case of setting the name attribute directly or do other patches need modifying as well? Apologise if it is a silly question, somewhat new to how this works! |
| // Constrained to last working version (2024.0.17) until https://github.com/iBotPeaches/Apktool/issues/3534 | ||
| // is addressed which is causing crashes during patching. | ||
| // See https://github.com/ReVanced/revanced-patches/issues/3099. | ||
| compatiblePackages = [CompatiblePackage("com.reddit.frontpage", ["2024.0.17"])] |
There was a problem hiding this comment.
| // Constrained to last working version (2024.0.17) until https://github.com/iBotPeaches/Apktool/issues/3534 | |
| // is addressed which is causing crashes during patching. | |
| // See https://github.com/ReVanced/revanced-patches/issues/3099. | |
| compatiblePackages = [CompatiblePackage("com.reddit.frontpage", ["2024.0.17"])] | |
| // Constrained to last working version (2024.17.0) until https://github.com/iBotPeaches/Apktool/issues/3534 | |
| // is addressed which is causing crashes during patching. | |
| // See https://github.com/ReVanced/revanced-patches/issues/3099. | |
| compatiblePackages = [CompatiblePackage("com.reddit.frontpage", ["2024.17.0"])] |
Wasn't the last working version 2024.17.0 and not 2024.0.17?
|
@ascopes why was the head repository deleted? Did another PR supersede this one? |
|
Ah whoops, I was removing an unused clone for another revanced project and accidentally deleted the wrong one... will reraise with the correct fixes as given above when I get some time as GitHub won't let me restore it from the web UI. Got the repo locally on my PC still so will repush and cherrypick the fix that was committed on top of this. Need to take some time to understand how things are structured so I get it right. Sorry about that! |
|
Reopened at #3192 |
Until GH-3099 is fixable and addressed, this limits the version of Reddit that can be
used to 2024.0.17 which is the last known working version.