-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP 2.6] Enabled SPOT Instance deployments on CI benchmarks #4281
base: 2.6
Are you sure you want to change the base?
Conversation
Automated performance analysis summaryThis comment was automatically generated given there is performance data available. In summary:
You can check a comparison in detail via the grafana link Comparison between master and cp.spot.2.6.Time Period from 30 days ago. (environment used: oss-standalone)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.6 #4281 +/- ##
==========================================
- Coverage 82.74% 82.69% -0.06%
==========================================
Files 176 176
Lines 31017 31017
==========================================
- Hits 25666 25649 -17
- Misses 5351 5368 +17 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we keep the vecsim cluster benchmarks?
@GuyAv46 i've removed the cluster envs from those benchmarks (the ones loading from rdb) given if you load from rdb the cluster benchmark wont run. This means we have 4 benchmarks for vecsim cluster (based on ann) but this PR is not reducing/increasing it. |
This pull request is stale because it has been open for 60 days with no activity. |
CP of #4279 into v2.6 branch.
This PR enables spot instance deployments as a 1st deployment option. If it fails it uses the default non spot deployment in an agnostic manner to the developer/CI runner.