Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoescape tags in parser-v2 #4517

Closed
wants to merge 4 commits into from
Closed

Conversation

nafraf
Copy link
Collaborator

@nafraf nafraf commented Mar 15, 2024

This PR was replaced by #4433

Description

auto escape on querying TAG fields following the @tag{my_match} syntax.

This change is done in parser-v2, without the need of a new DIALECT

Special meaning characters, should be escaped to be considered as part of a tag:
* prefix suffix infix
w' wildcard
$ parameter
| OR operator
{, }

Which issues this PR fixes

  1. MOD-5756

Main objects this PR modified

  1. lexer-v2
  2. parser-v2

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

@nafraf nafraf marked this pull request as ready for review March 15, 2024 05:21
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 86.64731% with 92 lines in your changes are missing coverage. Please review.

Project coverage is 85.52%. Comparing base (bee89e7) to head (c73c962).

Files Patch % Lines
src/query_parser/v2/lexer.c 82.29% 77 Missing ⚠️
src/query_parser/v2/parser.c 94.09% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4517      +/-   ##
==========================================
+ Coverage   85.44%   85.52%   +0.08%     
==========================================
  Files         188      188              
  Lines       32892    33281     +389     
==========================================
+ Hits        28103    28464     +361     
- Misses       4789     4817      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nafraf nafraf requested review from raz-mon and oshadmi March 15, 2024 14:02
@nafraf nafraf changed the title MOD-5756: Autoescape tags in parser-v2 Autoescape tags in parser-v2 May 6, 2024
@nafraf
Copy link
Collaborator Author

nafraf commented May 15, 2024

This PR was replaced by #4433 including the changes only in DIALECT 5.

@nafraf nafraf closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant