Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move argument validation exception to methods to allow JIT inlining. #4610

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

paulomorgado
Copy link
Contributor

With this PR the throw of ArgumentNullExceptions is moved to a separate method to allow for JIT inlining.

@lahma
Copy link
Collaborator

lahma commented Nov 25, 2023

JIT most likely won't inline such large methods.

@paulomorgado
Copy link
Contributor Author

JIT most likely won't inline such large methods.

The methods aren't large, because they are asynchronous methods and will be converted into state machines.

However, the first part of the execution, up until the first await can still be optimized. Admittedly, not very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants