Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for BaseUrl in C# base class not being used #4880

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

soligen2010
Copy link

@soligen2010 soligen2010 commented May 3, 2024

Fix to use the BaseUrl from the base class when there is a base class and GenerateBaseUrlProperty is not set.

See issue #4764

Edit: This is for C# code generation

Fix to use the BaseUrl from the base class when there is a base class and GenerateBaseUrlProperty is not set.
@soligen2010 soligen2010 changed the title Fix for BaseUrl in base class not being used Fix for BaseUrl in C# base class not being used May 3, 2024
Fixed If in template and added test case for when there is a base class
@soligen2010
Copy link
Author

Added new commit to fix the If statement and added a new test case for when there is a BaseClass.

@soligen2010
Copy link
Author

Can someone please help me understand why this PR is failing? Looking at the errors in the latest run it doesn't seem to me to be related to something I changed. Is there something more I need to do?

Removed the 4 extra spaces that caused the generated file to vary from the  verified file
@soligen2010
Copy link
Author

I finally got my local installation working properly and found that I had 4 extra spaces added to a line in the generated client which caused the file to not match the verified. Hopefully this time the workflow works.

@soligen2010
Copy link
Author

Everything runs successfully on my local machine. The workflow error is

"You must install or update .NET to run this application."

I don't understand how anything I did could cause this, and I can't do anything about what is installed on the workflow server.

Can someone please advise?

Thanks

@Numpsy
Copy link
Contributor

Numpsy commented May 7, 2024

"You must install or update .NET to run this application."

Looks like it's trying to run the tests as .NET 6.0, and the build agent only has 7.0/8.0 installed.

Possibly because the CI build is set to use macos-latest and that recently became macOS 14 running on ARM cpus? (so nothing specific to do with the change here)

@franklixuefei
Copy link

does this PR have any recent tractions?

@soligen2010
Copy link
Author

I don't know what you mean by "recent tractions" This PR addresses an issue that was first introduced in 14.0.1, possibly introduced by PR #4691. There were further changes in this area after that PR, but they didn't fix this issue.

I believe this PR fixes issues #4764 and #4705.

This PR is needed by anyone setting BaseUrl in a base class. For anyone who does this, the recent versions are not usable - they cant upgrade to the most recent version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants