Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #1777 Updated to with newer website design changes. #1798

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mukulj77
Copy link

@mukulj77 mukulj77 commented Nov 21, 2020

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

Description

Please add details about your change here.
I've added 'com.fasterxml.jackson' to pom dependencies because I needed to convert JSON to Java Objects.
The bugfix comprises of: So basically, problem was they have moved pagination markup generation logic to js and hence can no longer be accessed by the selectors on the markup. So, I had to fetch the contents of script tag and then parse to get the data required to generate next page url.

Please note: the java CLI is failing and so is 'mvn test' due to other ripper. All existing test cases of the current class passed successfully.

Testing

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

This is an expansive change. Added the fasterxml.jackson package to POM
for parsing the JSON object. TO-DO: Need to check the test cases.
Just improving the bug-fix. TO-DO: Need to check the test cases.
Conflicts:
	src/main/java/com/rarchives/ripme/ripper/rippers/XhamsterRipper.java
@mukulj77
Copy link
Author

POM dependencies added for the ripper (com.fasterxml.jackson)

@mukulj77 mukulj77 marked this pull request as ready for review November 21, 2020 19:25
@cyian-1756
Copy link
Collaborator

Worked for me, I'll get it merged for the next verson

@soloturn soloturn mentioned this pull request Nov 26, 2020
4 tasks
@soloturn
Copy link
Contributor

thanks @mukulj77 ! i copied 2 lines of your change in here: #1807 so the tests are green again.

@soloturn
Copy link
Contributor

included in:
https://github.com/ripmeapp2/ripme/actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xhamster photo galleries stopping download at 24 images.
3 participants