Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expressing Method via IRouter #1735

Merged
merged 1 commit into from May 6, 2024
Merged

Expressing Method via IRouter #1735

merged 1 commit into from May 6, 2024

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented May 6, 2024

This serves two purposes:

@RobinTail RobinTail added the refactoring The better way to achieve the same result label May 6, 2024
@RobinTail RobinTail marked this pull request as ready for review May 6, 2024 19:14
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 232f579 on ref-express-method
into cc3fff8 on master.

Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@RobinTail RobinTail merged commit f39c37e into master May 6, 2024
11 checks passed
@RobinTail RobinTail deleted the ref-express-method branch May 6, 2024 19:26
RobinTail added a commit that referenced this pull request May 6, 2024
This serves two purposes:

- Enforcing constraints on its actual usage in `walkRouting()`,
- Should ease adoption of the new `QUERY` method in the future, see:
  - expressjs/express#5615
  - nodejs/node#51562
RobinTail added a commit that referenced this pull request May 6, 2024
This serves two purposes:

- Enforcing constraints on its actual usage in `walkRouting()`,
- Should ease adoption of the new `QUERY` method in the future, see:
  - expressjs/express#5615
  - nodejs/node#51562
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring The better way to achieve the same result
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant